From 28980c3d6d989b900d02e3357473294561334e4a Mon Sep 17 00:00:00 2001 From: Joel Johnson <joel.johnson@issinc.com> Date: Mon, 29 Jun 2015 12:19:07 -0400 Subject: [PATCH] use JEE 3.0 to allow cookie session tracking --- src/main/java/com/gitblit/wicket/pages/SessionPage.java | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/SessionPage.java b/src/main/java/com/gitblit/wicket/pages/SessionPage.java index 0dda949..af7f211 100644 --- a/src/main/java/com/gitblit/wicket/pages/SessionPage.java +++ b/src/main/java/com/gitblit/wicket/pages/SessionPage.java @@ -96,7 +96,12 @@ .getAttribute(Constants.AUTHENTICATION_TYPE); // issue 62: fix session fixation vulnerability - session.replaceSession(); + // but only if authentication was done in the container. + // It avoid double change of session, that some authentication method + // don't like + if (AuthenticationType.CONTAINER != authenticationType) { + session.replaceSession(); + } session.setUser(user); request.getSession().setAttribute(Constants.AUTHENTICATION_TYPE, authenticationType); -- Gitblit v1.9.1