From 235ad956fa84cad4fac1b2e69a0c9e4f50376ea3 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 30 Sep 2013 10:10:48 -0400 Subject: [PATCH] Revise date label creation for optional css class --- src/main/java/com/gitblit/git/GitblitUploadPackFactory.java | 26 +++++++++++++++++--------- 1 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/gitblit/git/GitblitUploadPackFactory.java b/src/main/java/com/gitblit/git/GitblitUploadPackFactory.java index 85750f8..6c06fa3 100644 --- a/src/main/java/com/gitblit/git/GitblitUploadPackFactory.java +++ b/src/main/java/com/gitblit/git/GitblitUploadPackFactory.java @@ -15,23 +15,23 @@ */ package com.gitblit.git; +import java.util.ArrayList; +import java.util.List; import java.util.Map; import javax.servlet.http.HttpServletRequest; import org.eclipse.jgit.lib.Ref; import org.eclipse.jgit.lib.Repository; -import org.eclipse.jgit.transport.DaemonClient; import org.eclipse.jgit.transport.RefFilter; import org.eclipse.jgit.transport.UploadPack; import org.eclipse.jgit.transport.resolver.ServiceNotAuthorizedException; import org.eclipse.jgit.transport.resolver.ServiceNotEnabledException; import org.eclipse.jgit.transport.resolver.UploadPackFactory; +import com.gitblit.Constants; import com.gitblit.GitBlit; import com.gitblit.models.UserModel; -import com.gitblit.utils.IssueUtils; -import com.gitblit.utils.PushLogUtils; /** * The upload pack factory creates an upload pack which controls what refs are @@ -56,9 +56,9 @@ if (user == null) { user = UserModel.ANONYMOUS; } - } else if (req instanceof DaemonClient) { + } else if (req instanceof GitDaemonClient) { // git daemon request is always anonymous - DaemonClient client = (DaemonClient) req; + GitDaemonClient client = (GitDaemonClient) req; // set timeout from Git daemon timeout = client.getDaemon().getTimeout(); } @@ -90,10 +90,18 @@ return refs; } - // normal users can not clone gitblit refs - refs.remove(IssueUtils.GB_ISSUES); - refs.remove(PushLogUtils.GB_PUSHES); + // normal users can not clone any gitblit refs + // JGit's RefMap is custom and does not support iterator removal :( + List<String> toRemove = new ArrayList<String>(); + for (String ref : refs.keySet()) { + if (ref.startsWith(Constants.R_GITBLIT)) { + toRemove.add(ref); + } + } + for (String ref : toRemove) { + refs.remove(ref); + } return refs; } } -} +} \ No newline at end of file -- Gitblit v1.9.1