From 16e4747d3cb2c2a53a6bef554bca306d8594a080 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Fri, 14 Sep 2012 17:51:04 -0400 Subject: [PATCH] Mostly complete blob view line links feature, DOM offset bug remains (issue 130) --- src/com/gitblit/utils/MarkdownUtils.java | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/com/gitblit/utils/MarkdownUtils.java b/src/com/gitblit/utils/MarkdownUtils.java index c7c1f9f..828225d 100644 --- a/src/com/gitblit/utils/MarkdownUtils.java +++ b/src/com/gitblit/utils/MarkdownUtils.java @@ -20,6 +20,7 @@ import java.io.StringReader; import java.io.StringWriter; +import org.slf4j.LoggerFactory; import org.tautua.markdownpapers.Markdown; import org.tautua.markdownpapers.parser.ParseException; @@ -40,7 +41,12 @@ */ public static String transformMarkdown(String markdown) throws java.text.ParseException { try { - return transformMarkdown(new StringReader(markdown)); + StringReader reader = new StringReader(markdown); + String html = transformMarkdown(reader); + reader.close(); + return html; + } catch (IllegalArgumentException e) { + throw new java.text.ParseException(e.getMessage(), 0); } catch (NullPointerException p) { throw new java.text.ParseException("Markdown string is null!", 0); } @@ -62,13 +68,9 @@ md.transform(markdownReader, writer); return writer.toString().trim(); } catch (ParseException p) { + LoggerFactory.getLogger(MarkdownUtils.class).error("MarkdownPapers failed to parse Markdown!", p); throw new java.text.ParseException(p.getMessage(), 0); } finally { - try { - markdownReader.close(); - } catch (IOException e) { - // IGNORE - } try { writer.close(); } catch (IOException e) { -- Gitblit v1.9.1