From 13417cf9c6eec555b51da49742e47939d2f5715b Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Fri, 19 Oct 2012 22:47:33 -0400
Subject: [PATCH] Exclude submodules from zip downloads (issue 151)

---
 tests/com/gitblit/tests/RepositoryModelTest.java |   61 +++++++++++++++++-------------
 1 files changed, 35 insertions(+), 26 deletions(-)

diff --git a/tests/com/gitblit/tests/RepositoryModelTest.java b/tests/com/gitblit/tests/RepositoryModelTest.java
index 00bf0d0..1fe3fbd 100644
--- a/tests/com/gitblit/tests/RepositoryModelTest.java
+++ b/tests/com/gitblit/tests/RepositoryModelTest.java
@@ -1,6 +1,22 @@
+/*
+ * Copyright 2012 John Crygier
+ * Copyright 2012 gitblit.com
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.gitblit.tests;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 import org.eclipse.jgit.lib.Repository;
 import org.eclipse.jgit.lib.StoredConfig;
@@ -10,44 +26,33 @@
 import org.junit.BeforeClass;
 import org.junit.Test;
 
+import com.gitblit.Constants;
 import com.gitblit.GitBlit;
 import com.gitblit.models.RepositoryModel;
-import com.gitblit.utils.JGitUtils;
 
 public class RepositoryModelTest {
 	
-	private static String oldSection;
-	private static String oldSubSection;
 	private static boolean wasStarted = false;
 	
 	@BeforeClass
 	public static void startGitBlit() throws Exception {
 		wasStarted = GitBlitSuite.startGitblit() == false;
-		
-		oldSection = RepositoryModel.CUSTOM_DEFINED_PROP_SECTION;
-		oldSubSection = RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION;
-		
-		RepositoryModel.CUSTOM_DEFINED_PROP_SECTION = "RepositoryModelTest";
-		RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION = "RepositoryModelTestSubSection";
 	}
 	
 	@AfterClass
 	public static void stopGitBlit() throws Exception {
 		if (wasStarted == false)
 			GitBlitSuite.stopGitblit();
-		
-		RepositoryModel.CUSTOM_DEFINED_PROP_SECTION = oldSection;
-		RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION = oldSubSection;
 	}
 	
 	@Before
 	public void initializeConfiguration() throws Exception{
 		Repository r = GitBlitSuite.getHelloworldRepository();
-		StoredConfig config = JGitUtils.readConfig(r);
+		StoredConfig config = r.getConfig();
 		
-		config.unsetSection(RepositoryModel.CUSTOM_DEFINED_PROP_SECTION, RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION);
-		config.setString(RepositoryModel.CUSTOM_DEFINED_PROP_SECTION, RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION, "commitMessageRegEx", "\\d");
-		config.setString(RepositoryModel.CUSTOM_DEFINED_PROP_SECTION, RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION, "anotherProperty", "Hello");
+		config.unsetSection(Constants.CONFIG_GITBLIT, Constants.CONFIG_CUSTOM_FIELDS);
+		config.setString(Constants.CONFIG_GITBLIT, Constants.CONFIG_CUSTOM_FIELDS, "commitMessageRegEx", "\\d");
+		config.setString(Constants.CONFIG_GITBLIT, Constants.CONFIG_CUSTOM_FIELDS, "anotherProperty", "Hello");
 		
 		config.save();
 	}
@@ -55,9 +60,9 @@
 	@After
 	public void teardownConfiguration() throws Exception {
 		Repository r = GitBlitSuite.getHelloworldRepository();
-		StoredConfig config = JGitUtils.readConfig(r);
+		StoredConfig config = r.getConfig();
 		
-		config.unsetSection(RepositoryModel.CUSTOM_DEFINED_PROP_SECTION, RepositoryModel.CUSTOM_DEFINED_PROP_SUBSECTION);
+		config.unsetSection(Constants.CONFIG_GITBLIT, Constants.CONFIG_CUSTOM_FIELDS);
 		config.save();
 	}
 
@@ -66,8 +71,8 @@
 		RepositoryModel model = GitBlit.self().getRepositoryModel(
 				GitBlitSuite.getHelloworldRepository().getDirectory().getName());
 		
-		assertEquals("\\d", model.getCustomProperty("commitMessageRegEx"));
-		assertEquals("Hello", model.getCustomProperty("anotherProperty"));
+		assertEquals("\\d", model.customFields.get("commitMessageRegEx"));
+		assertEquals("Hello", model.customFields.get("anotherProperty"));
 	}
 	
 	@Test
@@ -75,13 +80,17 @@
 		RepositoryModel model = GitBlit.self().getRepositoryModel(
 				GitBlitSuite.getHelloworldRepository().getDirectory().getName());
 		
-		assertEquals("\\d", model.getCustomProperty("commitMessageRegEx"));
-		assertEquals("Hello", model.getCustomProperty("anotherProperty"));
+		assertEquals("\\d", model.customFields.get("commitMessageRegEx"));
+		assertEquals("Hello", model.customFields.get("anotherProperty"));
 		
-		assertEquals("Hello", model.setCustomProperty("anotherProperty", "GoodBye"));
+		assertEquals("Hello", model.customFields.put("anotherProperty", "GoodBye"));
+		GitBlit.self().updateRepositoryModel(model.name, model, false);
 		
-		assertEquals("\\d", model.getCustomProperty("commitMessageRegEx"));
-		assertEquals("GoodBye", model.getCustomProperty("anotherProperty"));
+		model = GitBlit.self().getRepositoryModel(
+				GitBlitSuite.getHelloworldRepository().getDirectory().getName());
+		
+		assertEquals("\\d", model.customFields.get("commitMessageRegEx"));
+		assertEquals("GoodBye", model.customFields.get("anotherProperty"));
 	}
 
 }

--
Gitblit v1.9.1