From 0d232164930581ccc9eac1b54e4c624a62f107bd Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Thu, 10 Apr 2014 18:58:08 -0400
Subject: [PATCH] Pass IGitblit into the SSH command context
---
src/main/java/com/gitblit/transport/ssh/SshDaemon.java | 101 ++++++++++++++++++++++++++++----------------------
1 files changed, 57 insertions(+), 44 deletions(-)
diff --git a/src/main/java/com/gitblit/transport/ssh/SshDaemon.java b/src/main/java/com/gitblit/transport/ssh/SshDaemon.java
index c11cb1f..b6c5d68 100644
--- a/src/main/java/com/gitblit/transport/ssh/SshDaemon.java
+++ b/src/main/java/com/gitblit/transport/ssh/SshDaemon.java
@@ -32,24 +32,13 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import com.gitblit.Constants;
import com.gitblit.IStoredSettings;
import com.gitblit.Keys;
-import com.gitblit.git.GitblitReceivePackFactory;
-import com.gitblit.git.GitblitUploadPackFactory;
-import com.gitblit.git.RepositoryResolver;
+import com.gitblit.manager.IAuthenticationManager;
import com.gitblit.manager.IGitblit;
-import com.gitblit.transport.ssh.commands.AddKeyCommand;
-import com.gitblit.transport.ssh.commands.CreateRepository;
-import com.gitblit.transport.ssh.commands.DispatchCommand;
-import com.gitblit.transport.ssh.commands.Receive;
-import com.gitblit.transport.ssh.commands.RemoveKeyCommand;
-import com.gitblit.transport.ssh.commands.ReviewCommand;
-import com.gitblit.transport.ssh.commands.SetAccountCommand;
-import com.gitblit.transport.ssh.commands.Upload;
-import com.gitblit.transport.ssh.commands.VersionCommand;
import com.gitblit.utils.IdGenerator;
import com.gitblit.utils.StringUtils;
-import com.gitblit.utils.WorkQueue;
import dagger.Module;
import dagger.ObjectGraph;
@@ -117,47 +106,47 @@
addr = new InetSocketAddress(bindInterface, port);
}
- PublicKeyAuthenticator publickeyAuthenticator = new PublicKeyAuthenticator(
- keyManager, gitblit);
+ File hostKeyStore = new File(gitblit.getBaseFolder(), HOST_KEY_STORE);
+ CachingPublicKeyAuthenticator keyAuthenticator =
+ getPublicKeyAuthenticator(keyManager, gitblit);
+
sshd = SshServer.setUpDefaultServer();
sshd.setPort(addr.getPort());
sshd.setHost(addr.getHostName());
- sshd.setKeyPairProvider(new PEMGeneratorHostKeyProvider(new File(
- gitblit.getBaseFolder(), HOST_KEY_STORE).getPath()));
- sshd.setPublickeyAuthenticator(publickeyAuthenticator);
+ sshd.setKeyPairProvider(new PEMGeneratorHostKeyProvider(hostKeyStore.getPath()));
+ sshd.setPublickeyAuthenticator(keyAuthenticator);
sshd.setPasswordAuthenticator(new UsernamePasswordAuthenticator(gitblit));
sshd.setSessionFactory(new SshServerSessionFactory());
sshd.setFileSystemFactory(new DisabledFilesystemFactory());
sshd.setTcpipForwardingFilter(new NonForwardingFilter());
+ sshd.setCommandFactory(new SshCommandFactory(gitblit, keyAuthenticator, idGenerator));
+ sshd.setShellFactory(new WelcomeShell(settings));
- DispatchCommand gitblitCmd = new DispatchCommand();
- gitblitCmd.registerCommand(CreateRepository.class);
- gitblitCmd.registerCommand(VersionCommand.class);
- gitblitCmd.registerCommand(AddKeyCommand.class);
- gitblitCmd.registerCommand(RemoveKeyCommand.class);
- gitblitCmd.registerCommand(SetAccountCommand.class);
- gitblitCmd.registerCommand(ReviewCommand.class);
-
- DispatchCommand gitCmd = new DispatchCommand();
- gitCmd.registerCommand(Upload.class);
- gitCmd.registerCommand(Receive.class);
-
- DispatchCommand root = new DispatchCommand();
- root.registerDispatcher("gitblit", gitblitCmd);
- root.registerDispatcher("git", gitCmd);
-
- root.setRepositoryResolver(new RepositoryResolver<SshDaemonClient>(gitblit));
- root.setUploadPackFactory(new GitblitUploadPackFactory<SshDaemonClient>(gitblit));
- root.setReceivePackFactory(new GitblitReceivePackFactory<SshDaemonClient>(gitblit));
- root.setAuthenticator(publickeyAuthenticator);
-
- SshCommandFactory commandFactory = new SshCommandFactory(
- new WorkQueue(idGenerator),
- root);
-
- sshd.setCommandFactory(commandFactory);
+ String version = Constants.getGitBlitVersion() + " (" + sshd.getVersion() + ")";
+ sshd.getProperties().put(SshServer.SERVER_IDENTIFICATION, version);
run = new AtomicBoolean(false);
+ }
+
+ private CachingPublicKeyAuthenticator getPublicKeyAuthenticator(
+ IKeyManager keyManager, IGitblit gitblit) {
+ IStoredSettings settings = gitblit.getSettings();
+ String clazz = settings.getString(Keys.git.sshPublicKeyAuthenticator,
+ CachingPublicKeyAuthenticator.class.getName());
+ if (StringUtils.isEmpty(clazz)) {
+ clazz = CachingPublicKeyAuthenticator.class.getName();
+ }
+ try {
+ Class<CachingPublicKeyAuthenticator> authClass =
+ (Class<CachingPublicKeyAuthenticator>) Class.forName(clazz);
+ return authClass.getConstructor(
+ new Class[] { IKeyManager.class,
+ IAuthenticationManager.class }).newInstance(
+ keyManager, gitblit);
+ } catch (Exception e) {
+ log.error("failed to create ssh auth manager " + clazz, e);
+ }
+ return null;
}
public String formatUrl(String gituser, String servername, String repository) {
@@ -215,6 +204,7 @@
}
}
+ @SuppressWarnings("unchecked")
protected IKeyManager getKeyManager() {
IKeyManager keyManager = null;
IStoredSettings settings = gitblit.getSettings();
@@ -237,6 +227,29 @@
return keyManager;
}
+ @SuppressWarnings("unchecked")
+ protected IKeyManager getKeyAuthenticator() {
+ IKeyManager keyManager = null;
+ IStoredSettings settings = gitblit.getSettings();
+ String clazz = settings.getString(Keys.git.sshKeysManager, FileKeyManager.class.getName());
+ if (StringUtils.isEmpty(clazz)) {
+ clazz = FileKeyManager.class.getName();
+ }
+ try {
+ Class<? extends IKeyManager> managerClass = (Class<? extends IKeyManager>) Class.forName(clazz);
+ keyManager = injector.get(managerClass).start();
+ if (keyManager.isReady()) {
+ log.info("{} is ready.", keyManager);
+ } else {
+ log.warn("{} is disabled.", keyManager);
+ }
+ } catch (Exception e) {
+ log.error("failed to create ssh key manager " + clazz, e);
+ keyManager = injector.get(NullKeyManager.class).start();
+ }
+ return keyManager;
+ }
+
/**
* A nested Dagger graph is used for constructor dependency injection of
* complex classes.
--
Gitblit v1.9.1