From 0451e04bc76eabf11b5f6e02b5323aceb464d4b8 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Sat, 07 Jan 2012 16:38:58 -0500 Subject: [PATCH] Updated screenshots take 2 --- src/com/gitblit/GitFilter.java | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/com/gitblit/GitFilter.java b/src/com/gitblit/GitFilter.java index 3011413..a7f0fe7 100644 --- a/src/com/gitblit/GitFilter.java +++ b/src/com/gitblit/GitFilter.java @@ -61,7 +61,7 @@ * Analyze the url and returns the action of the request. Return values are * either "/git-receive-pack" or "/git-upload-pack". * - * @param url + * @param serverUrl * @return action of the request */ @Override @@ -74,6 +74,8 @@ } else if (suffix.contains("?service=git-receive-pack")) { return gitReceivePack; } else if (suffix.contains("?service=git-upload-pack")) { + return gitUploadPack; + } else { return gitUploadPack; } } @@ -106,11 +108,12 @@ // Git Servlet disabled return false; } - if (repository.isFrozen || repository.accessRestriction.atLeast(AccessRestrictionType.PUSH)) { - boolean authorizedUser = user.canAccessRepository(repository.name); + boolean readOnly = repository.isFrozen; + if (readOnly || repository.accessRestriction.atLeast(AccessRestrictionType.PUSH)) { + boolean authorizedUser = user.canAccessRepository(repository); if (action.equals(gitReceivePack)) { // Push request - if (!repository.isFrozen && authorizedUser) { + if (!readOnly && authorizedUser) { // clone-restricted or push-authorized return true; } else { -- Gitblit v1.9.1