Eliminate redundant read() and use accessor instead of direct cache access

James Moger

2013-09-23 b2d7f418bf289e5fa6149ac1b5744cfb03b60dea

Eliminate redundant read() and use accessor instead of direct cache access

 src/main/java/com/gitblit/ConfigUserService.java

@@ -186,8 +186,7 @@
        if (!StringUtils.isEmpty(model.cookie)) {

            return model.cookie;

        }

        read();

        UserModel storedModel = users.get(model.username.toLowerCase());

        UserModel storedModel = getUserModel(model.username);

        if (storedModel == null) {

            return null;

        }

@@ -229,7 +228,6 @@
     */

    @Override

    public UserModel authenticate(String username, char[] password) {

        read();

        UserModel returnedUser = null;

        UserModel user = getUserModel(username);

        if (user == null) {