fix NullPointerException in ITicketService and add TestCase

Kevin Walter

2014-04-14 4868740ed7f40ce0cf162f17a8224856ae10a4b0

fix NullPointerException in ITicketService and add TestCase

 src/main/java/com/gitblit/tickets/ITicketService.java

@@ -714,9 +714,12 @@
        TicketKey key = new TicketKey(repository, ticketId);
        TicketModel ticket = ticketsCache.getIfPresent(key);

        // if ticket not cached
        if (ticket == null) {
            // load & cache ticket
            //load ticket
            ticket = getTicketImpl(repository, ticketId);
            // if ticket exists
            if (ticket != null) {
            if (ticket.hasPatchsets()) {
                Repository r = repositoryManager.getRepository(repository.name);
                try {
@@ -733,7 +736,7 @@
                    r.close();
                }
            }
            if (ticket != null) {
                //cache ticket
                ticketsCache.put(key, ticket);
            }
        }

 src/test/java/com/gitblit/tests/TicketServiceTest.java

@@ -92,6 +92,10 @@


    @Test

    public void testLifecycle() throws Exception {

        // query non-existent ticket

        TicketModel nonExistent = service.getTicket(getRepository(), 0);

        assertNull(nonExistent);

		
        // create and insert a ticket

        Change c1 = newChange("testCreation() " + Long.toHexString(System.currentTimeMillis()));

        TicketModel ticket = service.createTicket(getRepository(), c1);