Fixes findbugs warning - dereferencing null in exception case

Simon Harrer

2013-07-18 fbe265fa787e4be9cb63c6bae2ef30b9400d9afc

 src/main/java/com/gitblit/wicket/pages/OverviewPage.java

@@ -41,7 +41,7 @@
import com.gitblit.wicket.charting.GoogleLineChart;

import com.gitblit.wicket.panels.BranchesPanel;

import com.gitblit.wicket.panels.LinkPanel;

import com.gitblit.wicket.panels.PushesPanel;

import com.gitblit.wicket.panels.ReflogPanel;

import com.gitblit.wicket.panels.RepositoryUrlPanel;

import com.gitblit.wicket.panels.TagsPanel;



@@ -78,12 +78,16 @@
         private static final long serialVersionUID = 1L;

         int counter = 0;

         public void populateItem(final Item<String> item) {

            UserModel ownerModel = GitBlit.self().getUserModel(item.getModelObject());

            String ownername = item.getModelObject();

            UserModel ownerModel = GitBlit.self().getUserModel(ownername);

            if (ownerModel != null) {

               item.add(new LinkPanel("owner", null, ownerModel.getDisplayName(), UserPage.class,

                     WicketUtils.newUsernameParameter(ownerModel.username)).setRenderBodyOnly(true));

            } else {

               item.add(new Label("owner").setVisible(false));

               Label owner = new Label("owner", ownername);

               WicketUtils.setCssStyle(owner, "text-decoration: line-through;");

               WicketUtils.setHtmlTooltip(owner,  MessageFormat.format(getString("gb.failedToFindAccount"), ownername));

               item.add(owner);

            }

            counter++;

            item.add(new Label("comma", ",").setVisible(counter < owners.size()));

@@ -94,7 +98,7 @@
      add(ownersView);

      

      add(WicketUtils.createTimestampLabel("repositoryLastChange",

            JGitUtils.getLastChange(r), getTimeZone(), getTimeUtils()));

            JGitUtils.getLastChange(r).when, getTimeZone(), getTimeUtils()));

      add(new Label("repositorySize", model.size));

      

      if (metricsTotal == null) {

@@ -109,9 +113,9 @@


      add(new RepositoryUrlPanel("repositoryUrlPanel", false, user, model));



      int pushCount = GitBlit.getInteger(Keys.web.overviewPushCount, 5);

      PushesPanel pushes = new PushesPanel("pushesPanel", getRepositoryModel(), r, pushCount, 0, false);

      add(pushes);

      int reflogCount = GitBlit.getInteger(Keys.web.overviewReflogCount, 5);

      ReflogPanel reflog = new ReflogPanel("reflogPanel", getRepositoryModel(), r, reflogCount, 0);

      add(reflog);

      add(new TagsPanel("tagsPanel", repositoryName, r, numberRefs).hideIfEmpty());

      add(new BranchesPanel("branchesPanel", getRepositoryModel(), r, numberRefs, false).hideIfEmpty());