Fixed session fixation vulnerability (issue 62)

James Moger

2012-02-09 e7883877a98dfcae3f75f1c1a562120d89aed22a

 tests/com/gitblit/tests/JGitUtilsTest.java

@@ -66,7 +66,7 @@


   @Test

   public void testFindRepositories() {

      List<String> list = JGitUtils.getRepositoryList(null, true, true);

      List<String> list = JGitUtils.getRepositoryList(null, false, true);

      assertEquals(0, list.size());

      list.addAll(JGitUtils.getRepositoryList(new File("DoesNotExist"), true, true));

      assertEquals(0, list.size());

@@ -212,13 +212,35 @@
      assertEquals("183474d554e6f68478a02d9d7888b67a9338cdff", list.get(0).notesRef

            .getReferencedObjectId().getName());

   }

	
   @Test

   public void testRelinkHEAD() throws Exception {

      Repository repository = GitBlitSuite.getJGitRepository();

      // confirm HEAD is master

      String currentRef = JGitUtils.getHEADRef(repository);

      assertEquals("refs/heads/master", currentRef);

      List<String> availableHeads = JGitUtils.getAvailableHeadTargets(repository);

      assertTrue(availableHeads.size() > 0);

		
      // set HEAD to stable-1.2

      JGitUtils.setHEADtoRef(repository, "refs/heads/stable-1.2");

      currentRef = JGitUtils.getHEADRef(repository);

      assertEquals("refs/heads/stable-1.2", currentRef);



      // restore HEAD to master

      JGitUtils.setHEADtoRef(repository, "refs/heads/master");

      currentRef = JGitUtils.getHEADRef(repository);

      assertEquals("refs/heads/master", currentRef);

		
      repository.close();

   }



   @Test

   public void testCreateOrphanedBranch() throws Exception {

      Repository repository = JGitUtils.createRepository(GitBlitSuite.REPOSITORIES, "orphantest");

      assertTrue(JGitUtils.createOrphanBranch(repository,

            "x" + Long.toHexString(System.currentTimeMillis()).toUpperCase()));

      FileUtils.delete(repository.getDirectory(), FileUtils.RECURSIVE);

            "x" + Long.toHexString(System.currentTimeMillis()).toUpperCase(), null));

       FileUtils.delete(repository.getDirectory(), FileUtils.RECURSIVE);

   }



   @Test

@@ -333,6 +355,16 @@
   }



   @Test

   public void testRevLogRange() throws Exception {

      Repository repository = GitBlitSuite.getHelloworldRepository();

      List<RevCommit> commits = JGitUtils.getRevLog(repository,

            "fbd14fa6d1a01d4aefa1fca725792683800fc67e",

            "85a0e4087b8439c0aa6b1f4f9e08c26052ab7e87");

      repository.close();

      assertEquals(14, commits.size());

   }



   @Test

   public void testSearchTypes() throws Exception {

      assertEquals(SearchType.COMMIT, SearchType.forName("commit"));

      assertEquals(SearchType.COMMITTER, SearchType.forName("committer"));