James Moger
2012-01-05 cb285cbfddfc0b633d6b8cdb4dc0d2bd2b8b51ef
src/com/gitblit/wicket/pages/EditUserPage.java
@@ -1,12 +1,29 @@
/*
 * Copyright 2011 gitblit.com.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.gitblit.wicket.pages;
import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import org.apache.wicket.PageParameters;
import org.apache.wicket.extensions.markup.html.form.palette.Palette;
import org.apache.wicket.markup.html.form.Button;
import org.apache.wicket.markup.html.form.CheckBox;
import org.apache.wicket.markup.html.form.ChoiceRenderer;
import org.apache.wicket.markup.html.form.Form;
@@ -16,22 +33,20 @@
import org.apache.wicket.model.Model;
import org.apache.wicket.model.util.CollectionModel;
import org.apache.wicket.model.util.ListModel;
import org.eclipse.jetty.http.security.Credential.Crypt;
import org.eclipse.jetty.http.security.Credential.MD5;
import com.gitblit.Constants.AccessRestrictionType;
import com.gitblit.GitBlit;
import com.gitblit.GitBlitException;
import com.gitblit.Keys;
import com.gitblit.models.RepositoryModel;
import com.gitblit.models.TeamModel;
import com.gitblit.models.UserModel;
import com.gitblit.utils.StringUtils;
import com.gitblit.wicket.AdminPage;
import com.gitblit.wicket.BasePage;
import com.gitblit.wicket.RequiresAdminRole;
import com.gitblit.wicket.WicketUtils;
import com.gitblit.wicket.models.RepositoryModel;
import com.gitblit.wicket.models.UserModel;
@AdminPage
public class EditUserPage extends BasePage {
@RequiresAdminRole
public class EditUserPage extends RootSubPage {
   private final boolean isCreate;
@@ -53,11 +68,13 @@
   protected void setupPage(final UserModel userModel) {
      if (isCreate) {
         super.setupPage("", getString("gb.newUser"));
         super.setupPage(getString("gb.newUser"), "");
      } else {
         super.setupPage("", getString("gb.edit"));
         super.setupPage(getString("gb.edit"), userModel.username);
      }
      final Model<String> confirmPassword = new Model<String>(StringUtils.isEmpty(userModel.getPassword()) ? "" : userModel.getPassword());
      final Model<String> confirmPassword = new Model<String>(
            StringUtils.isEmpty(userModel.password) ? "" : userModel.password);
      CompoundPropertyModel<UserModel> model = new CompoundPropertyModel<UserModel>(userModel);
      List<String> repos = new ArrayList<String>();
@@ -67,7 +84,19 @@
            repos.add(repo);
         }
      }
      final Palette<String> repositories = new Palette<String>("repositories", new ListModel<String>(userModel.getRepositories()), new CollectionModel<String>(repos), new ChoiceRenderer<String>("", ""), 10, false);
      List<String> userTeams = new ArrayList<String>();
      for (TeamModel team : userModel.teams) {
         userTeams.add(team.name);
      }
      Collections.sort(userTeams);
      final String oldName = userModel.username;
      final Palette<String> repositories = new Palette<String>("repositories",
            new ListModel<String>(new ArrayList<String>(userModel.repositories)),
            new CollectionModel<String>(repos), new ChoiceRenderer<String>("", ""), 10, false);
      final Palette<String> teams = new Palette<String>("teams", new ListModel<String>(
            new ArrayList<String>(userTeams)), new CollectionModel<String>(GitBlit.self()
            .getAllTeamnames()), new ChoiceRenderer<String>("", ""), 10, false);
      Form<UserModel> form = new Form<UserModel>("editForm", model) {
         private static final long serialVersionUID = 1L;
@@ -79,7 +108,7 @@
          */
         @Override
         protected void onSubmit() {
            String username = userModel.getUsername();
            String username = userModel.username;
            if (StringUtils.isEmpty(username)) {
               error("Please enter a username!");
               return;
@@ -87,46 +116,69 @@
            if (isCreate) {
               UserModel model = GitBlit.self().getUserModel(username);
               if (model != null) {
                  error(MessageFormat.format("Username {0} is unavailable.", username));
                  error(MessageFormat.format("Username ''{0}'' is unavailable.", username));
                  return;
               }
            }
            if (!userModel.getPassword().equals(confirmPassword.getObject())) {
            boolean rename = !StringUtils.isEmpty(oldName)
                  && !oldName.equalsIgnoreCase(username);
            if (!userModel.password.equals(confirmPassword.getObject())) {
               error("Passwords do not match!");
               return;
            }
            String password = userModel.getPassword();
            if (!password.toUpperCase().startsWith(Crypt.__TYPE) && !password.toUpperCase().startsWith(MD5.__TYPE)) {
            String password = userModel.password;
            if (!password.toUpperCase().startsWith(StringUtils.MD5_TYPE)
                  && !password.toUpperCase().startsWith(StringUtils.COMBINED_MD5_TYPE)) {
               // This is a plain text password.
               // Check length.
               int minLength = GitBlit.self().settings().getInteger(Keys.realm.minPasswordLength, 5);
               int minLength = GitBlit.getInteger(Keys.realm.minPasswordLength, 5);
               if (minLength < 4) {
                  minLength = 4;
               }
               if (password.trim().length() < minLength) {
                  error(MessageFormat.format("Password is too short. Minimum length is {0} characters.", minLength));
                  error(MessageFormat.format(
                        "Password is too short. Minimum length is {0} characters.",
                        minLength));
                  return;
               }
               // Optionally encrypt/obfuscate the password.
               String type = GitBlit.self().settings().getString(Keys.realm.passwordStorage, "md5");
               // Optionally store the password MD5 digest.
               String type = GitBlit.getString(Keys.realm.passwordStorage, "md5");
               if (type.equalsIgnoreCase("md5")) {
                  // store MD5 checksum of password
                  userModel.setPassword(MD5.digest(userModel.getPassword()));
               } else if (type.equalsIgnoreCase("crypt")) {
                  // simple unix encryption
                  userModel.setPassword(Crypt.crypt(userModel.getUsername(), userModel.getPassword()));
                  // store MD5 digest of password
                  userModel.password = StringUtils.MD5_TYPE
                        + StringUtils.getMD5(userModel.password);
               } else if (type.equalsIgnoreCase("combined-md5")) {
                  // store MD5 digest of username+password
                  userModel.password = StringUtils.COMBINED_MD5_TYPE
                        + StringUtils.getMD5(username.toLowerCase() + userModel.password);
               }
            } else if (rename
                  && password.toUpperCase().startsWith(StringUtils.COMBINED_MD5_TYPE)) {
               error("Gitblit is configured for combined-md5 password hashing. You must enter a new password on account rename.");
               return;
            }
            Iterator<String> selectedRepositories = repositories.getSelectedChoices();
            List<String> repos = new ArrayList<String>();
            while (selectedRepositories.hasNext()) {
               repos.add(selectedRepositories.next());
               repos.add(selectedRepositories.next().toLowerCase());
            }
            userModel.setRepositories(repos);
            userModel.repositories.clear();
            userModel.repositories.addAll(repos);
            Iterator<String> selectedTeams = teams.getSelectedChoices();
            userModel.teams.clear();
            while (selectedTeams.hasNext()) {
               TeamModel team = GitBlit.self().getTeamModel(selectedTeams.next());
               if (team == null) {
                  continue;
               }
               userModel.teams.add(team);
            }
            try {
               GitBlit.self().editUserModel(userModel, isCreate);
               GitBlit.self().updateUserModel(oldName, userModel, isCreate);
            } catch (GitBlitException e) {
               error(e.getMessage());
               return;
@@ -134,25 +186,42 @@
            setRedirect(false);
            if (isCreate) {
               // create another user
               info(MessageFormat.format("New user {0} successfully created.", userModel.getUsername()));
               info(MessageFormat.format("New user ''{0}'' successfully created.",
                     userModel.username));
               setResponsePage(EditUserPage.class);
            } else {
               // back to home
               setResponsePage(RepositoriesPage.class);
               // back to users page
               setResponsePage(UsersPage.class);
            }
         }
      };
      // field names reflective match UserModel fields
      form.add(new TextField<String>("username").setEnabled(isCreate));
      form.add(new TextField<String>("username"));
      PasswordTextField passwordField = new PasswordTextField("password");
      passwordField.setResetPassword(false);
      form.add(passwordField);
      PasswordTextField confirmPasswordField = new PasswordTextField("confirmPassword", confirmPassword);
      PasswordTextField confirmPasswordField = new PasswordTextField("confirmPassword",
            confirmPassword);
      confirmPasswordField.setResetPassword(false);
      form.add(confirmPasswordField);
      form.add(new CheckBox("canAdmin"));
      form.add(new CheckBox("excludeFromFederation"));
      form.add(repositories);
      form.add(teams);
      form.add(new Button("save"));
      Button cancel = new Button("cancel") {
         private static final long serialVersionUID = 1L;
         @Override
         public void onSubmit() {
            setResponsePage(UsersPage.class);
         }
      };
      cancel.setDefaultFormProcessing(false);
      form.add(cancel);
      add(form);
   }
}