Fixed bug in receive hook for repositories in subfolders

James Moger

2012-01-05 cb285cbfddfc0b633d6b8cdb4dc0d2bd2b8b51ef

 src/com/gitblit/FederationPullExecutor.java

@@ -15,22 +15,28 @@
 */

package com.gitblit;



import static org.eclipse.jgit.lib.Constants.DOT_GIT_EXT;



import java.io.File;

import java.io.FileOutputStream;

import java.io.IOException;

import java.net.InetAddress;

import java.text.MessageFormat;

import java.util.ArrayList;

import java.util.Arrays;

import java.util.Collection;

import java.util.Date;

import java.util.HashSet;

import java.util.List;

import java.util.Map;

import java.util.Properties;

import java.util.Set;

import java.util.concurrent.TimeUnit;



import org.eclipse.jgit.lib.Ref;

import org.eclipse.jgit.lib.Repository;

import org.eclipse.jgit.lib.StoredConfig;

import org.eclipse.jgit.revwalk.RevCommit;

import org.eclipse.jgit.transport.CredentialsProvider;

import org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider;

import org.slf4j.Logger;

@@ -38,10 +44,14 @@


import com.gitblit.Constants.FederationPullStatus;

import com.gitblit.Constants.FederationStrategy;

import com.gitblit.GitBlitException.ForbiddenException;

import com.gitblit.models.FederationModel;

import com.gitblit.models.RepositoryModel;

import com.gitblit.models.TeamModel;

import com.gitblit.models.UserModel;

import com.gitblit.utils.ArrayUtils;

import com.gitblit.utils.FederationUtils;

import com.gitblit.utils.FileUtils;

import com.gitblit.utils.JGitUtils;

import com.gitblit.utils.JGitUtils.CloneResult;

import com.gitblit.utils.StringUtils;

@@ -57,6 +67,8 @@


   private final List<FederationModel> registrations;



   private final boolean isDaemon;



   /**

    * Constructor for specifying a single federation registration. This

    * constructor is used to schedule the next pull execution.

@@ -64,7 +76,7 @@
    * @param registration

    */

   private FederationPullExecutor(FederationModel registration) {

      this(Arrays.asList(registration));

      this(Arrays.asList(registration), true);

   }



   /**

@@ -73,9 +85,13 @@
    * on each registrations frequency setting.

    * 

    * @param registrations

    * @param isDaemon

    *            if true, registrations are rescheduled in perpetuity. if

    *            false, the federation pull operation is executed once.

    */

   public FederationPullExecutor(List<FederationModel> registrations) {

   public FederationPullExecutor(List<FederationModel> registrations, boolean isDaemon) {

      this.registrations = registrations;

      this.isDaemon = isDaemon;

   }



   /**

@@ -99,7 +115,7 @@
                  String message = "Federation pull of " + registration.name + " @ "

                        + registration.url + " is now at " + is.name();

                  GitBlit.self()

                        .notifyAdministrators(

                        .sendMailToAdministrators(

                              "Pull Status of " + registration.name + " is " + is.name(),

                              message);

               }

@@ -109,7 +125,9 @@
                  "Failed to pull from federated gitblit ({0} @ {1})", registration.name,

                  registration.url), t);

         } finally {

            schedule(registration);

            if (isDaemon) {

               schedule(registration);

            }

         }

      }

   }

@@ -149,11 +167,25 @@
            continue;

         }



         // Determine local repository name

         String repositoryName;

         if (StringUtils.isEmpty(registrationFolder)) {

            repositoryName = repository.name;

         } else {

            repositoryName = registrationFolder + "/" + repository.name;

         }



         if (registration.bare) {

            // bare repository, ensure .git suffix

            if (!repositoryName.toLowerCase().endsWith(DOT_GIT_EXT)) {

               repositoryName += DOT_GIT_EXT;

            }

         } else {

            // normal repository, strip .git suffix

            if (repositoryName.toLowerCase().endsWith(DOT_GIT_EXT)) {

               repositoryName = repositoryName.substring(0,

                     repositoryName.indexOf(DOT_GIT_EXT));

            }

         }



         // confirm that the origin of any pre-existing repository matches

@@ -164,8 +196,11 @@
            StoredConfig config = existingRepository.getConfig();

            config.load();

            String origin = config.getString("remote", "origin", "url");

            fetchHead = JGitUtils.getCommit(existingRepository, "refs/remotes/origin/master")

                  .getName();

            RevCommit commit = JGitUtils.getCommit(existingRepository,

                  "refs/remotes/origin/master");

            if (commit != null) {

               fetchHead = commit.getName();

            }

            existingRepository.close();

            if (!origin.startsWith(registration.url)) {

               logger.warn(MessageFormat

@@ -181,6 +216,7 @@
               Constants.FEDERATION_USER, registration.token);

         logger.info(MessageFormat.format("Pulling federated repository {0} from {1} @ {2}",

               repository.name, registration.name, registration.url));



         CloneResult result = JGitUtils.cloneRepository(registrationFolderFile, repository.name,

               cloneUrl, registration.bare, credentials);

         Repository r = GitBlit.self().getRepository(repositoryName);

@@ -196,8 +232,9 @@
         } else {

            // fetch and update

            boolean fetched = false;

            String origin = JGitUtils.getCommit(r, "refs/remotes/origin/master").getName();

            fetched = !fetchHead.equals(origin);

            RevCommit commit = JGitUtils.getCommit(r, "refs/remotes/origin/master");

            String origin = commit.getName();

            fetched = fetchHead == null || !fetchHead.equals(origin);



            if (registration.mirror) {

               // mirror

@@ -225,6 +262,16 @@
            // preserve local settings

            repository.isFrozen = rm.isFrozen;

            repository.federationStrategy = rm.federationStrategy;



            // merge federation sets

            Set<String> federationSets = new HashSet<String>();

            if (rm.federationSets != null) {

               federationSets.addAll(rm.federationSets);

            }

            if (repository.federationSets != null) {

               federationSets.addAll(repository.federationSets);

            }

            repository.federationSets = new ArrayList<String>(federationSets);

         }

         // only repositories that are actually _cloned_ from the origin

         // Gitblit repository are marked as federated. If the origin

@@ -236,14 +283,18 @@
         r.close();

      }



      IUserService userService = null;



      try {

         // Pull USERS

         // TeamModels are automatically pulled because they are contained

         // within the UserModel. The UserService creates unknown teams

         // and updates existing teams.

         Collection<UserModel> users = FederationUtils.getUsers(registration);

         if (users != null && users.size() > 0) {

            File realmFile = new File(registrationFolderFile, registration.name

                  + "_users.properties");

            File realmFile = new File(registrationFolderFile, registration.name + "_users.conf");

            realmFile.delete();

            FileUserService userService = new FileUserService(realmFile);

            userService = new ConfigUserService(realmFile);

            for (UserModel user : users) {

               userService.updateUserModel(user.username, user);



@@ -274,16 +325,61 @@
                     localUser.canAdmin = user.canAdmin;

                     GitBlit.self().updateUserModel(localUser.username, localUser, false);

                  }



                  for (String teamname : GitBlit.self().getAllTeamnames()) {

                     TeamModel team = GitBlit.self().getTeamModel(teamname);

                     if (user.isTeamMember(teamname) && !team.hasUser(user.username)) {

                        // new team member

                        team.addUser(user.username);

                        GitBlit.self().updateTeamModel(teamname, team, false);

                     } else if (!user.isTeamMember(teamname) && team.hasUser(user.username)) {

                        // remove team member

                        team.removeUser(user.username);

                        GitBlit.self().updateTeamModel(teamname, team, false);

                     }



                     // update team repositories

                     TeamModel remoteTeam = user.getTeam(teamname);

                     if (remoteTeam != null && !ArrayUtils.isEmpty(remoteTeam.repositories)) {

                        int before = team.repositories.size();

                        team.addRepositories(remoteTeam.repositories);

                        int after = team.repositories.size();

                        if (after > before) {

                           // repository count changed, update

                           GitBlit.self().updateTeamModel(teamname, team, false);

                        }

                     }

                  }

               }

            }

         }

      } catch (Exception e) {

         // a 403 error code is normal for a PULL_REPOSITORIES token

         if (!e.getMessage().contains("403")) {

            logger.warn(MessageFormat.format(

                  "Failed to retrieve USERS from federated gitblit ({0} @ {1})",

                  registration.name, registration.url), e);

      } catch (ForbiddenException e) {

         // ignore forbidden exceptions

      } catch (IOException e) {

         logger.warn(MessageFormat.format(

               "Failed to retrieve USERS from federated gitblit ({0} @ {1})",

               registration.name, registration.url), e);

      }



      try {

         // Pull TEAMS

         // We explicitly pull these even though they are embedded in

         // UserModels because it is possible to use teams to specify

         // mailing lists or push scripts without specifying users.

         if (userService != null) {

            Collection<TeamModel> teams = FederationUtils.getTeams(registration);

            if (teams != null && teams.size() > 0) {

               for (TeamModel team : teams) {

                  userService.updateTeamModel(team);

               }

            }

         }

      } catch (ForbiddenException e) {

         // ignore forbidden exceptions

      } catch (IOException e) {

         logger.warn(MessageFormat.format(

               "Failed to retrieve TEAMS from federated gitblit ({0} @ {1})",

               registration.name, registration.url), e);

      }



      try {

@@ -297,13 +393,34 @@
            properties.store(os, null);

            os.close();

         }

      } catch (Exception e) {

         // a 403 error code is normal for a PULL_REPOSITORIES token

         if (!e.getMessage().contains("403")) {

            logger.warn(MessageFormat.format(

                  "Failed to retrieve SETTINGS from federated gitblit ({0} @ {1})",

                  registration.name, registration.url), e);

      } catch (ForbiddenException e) {

         // ignore forbidden exceptions

      } catch (IOException e) {

         logger.warn(MessageFormat.format(

               "Failed to retrieve SETTINGS from federated gitblit ({0} @ {1})",

               registration.name, registration.url), e);

      }



      try {

         // Pull SCRIPTS

         Map<String, String> scripts = FederationUtils.getScripts(registration);

         if (scripts != null && scripts.size() > 0) {

            for (Map.Entry<String, String> script : scripts.entrySet()) {

               String scriptName = script.getKey();

               if (scriptName.endsWith(".groovy")) {

                  scriptName = scriptName.substring(0, scriptName.indexOf(".groovy"));

               }

               File file = new File(registrationFolderFile, registration.name + "_"

                     + scriptName + ".groovy");

               FileUtils.writeContent(file, script.getValue());

            }

         }

      } catch (ForbiddenException e) {

         // ignore forbidden exceptions

      } catch (IOException e) {

         logger.warn(MessageFormat.format(

               "Failed to retrieve SCRIPTS from federated gitblit ({0} @ {1})",

               registration.name, registration.url), e);

      }

   }