Improvements to handling internal accounts (anonymous, federation user)

James Moger

2013-07-02 b5798e1e6cf15da4eb33647190e127b53410c620

 src/main/java/com/gitblit/AuthenticationFilter.java

@@ -28,6 +28,7 @@
import javax.servlet.ServletRequest;

import javax.servlet.ServletResponse;

import javax.servlet.http.HttpServletRequest;

import javax.servlet.http.HttpServletRequestWrapper;

import javax.servlet.http.HttpServletResponse;

import javax.servlet.http.HttpSession;



@@ -35,6 +36,7 @@
import org.slf4j.LoggerFactory;



import com.gitblit.models.UserModel;

import com.gitblit.utils.DeepCopier;

import com.gitblit.utils.StringUtils;



/**

@@ -105,7 +107,6 @@
   /**

    * Taken from Jetty's LoginAuthenticator.renewSessionOnAuthentication()

    */

   @SuppressWarnings("unchecked")

   protected void newSession(HttpServletRequest request, HttpServletResponse response) {

      HttpSession oldSession = request.getSession(false);

      if (oldSession != null && oldSession.getAttribute(SESSION_SECURED) == null) {

@@ -145,14 +146,13 @@
   /**

    * Wraps a standard HttpServletRequest and overrides user principal methods.

    */

   public static class AuthenticatedRequest extends ServletRequestWrapper {

   public static class AuthenticatedRequest extends HttpServletRequestWrapper {



      private UserModel user;



      public AuthenticatedRequest(HttpServletRequest req) {

         super(req);

         user = new UserModel("anonymous");

         user.isAuthenticated = false;

         user = DeepCopier.copy(UserModel.ANONYMOUS);

      }



      UserModel getUser() {