Paul Martin
2016-04-30 a502d96a860456ec5e8c96761db70f7cabb74751
src/main/java/com/gitblit/wicket/pages/NewTicketPage.java
@@ -19,8 +19,12 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import java.util.TreeSet;
import org.apache.wicket.PageParameters;
import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.form.AjaxButton;
import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.markup.html.form.Button;
import org.apache.wicket.markup.html.form.DropDownChoice;
@@ -33,6 +37,7 @@
import com.gitblit.Constants;
import com.gitblit.Constants.AccessPermission;
import com.gitblit.Constants.AuthorizationControl;
import com.gitblit.models.RegistrantAccessPermission;
import com.gitblit.models.TicketModel;
import com.gitblit.models.TicketModel.Change;
@@ -71,6 +76,10 @@
   private Label descriptionPreview;
   private IModel<TicketModel.Priority> priorityModel;
   private IModel<TicketModel.Severity> severityModel;
   public NewTicketPage(PageParameters params) {
      super(params);
@@ -87,22 +96,110 @@
      typeModel = Model.of(TicketModel.Type.defaultType);
      titleModel = Model.of();
      topicModel = Model.of();
      mergeToModel = Model.of(Repository.shortenRefName(getRepositoryModel().HEAD));
      mergeToModel = Model.of(Repository.shortenRefName(getRepositoryModel().mergeTo));
      responsibleModel = Model.of();
      milestoneModel = Model.of();
      severityModel = Model.of(TicketModel.Severity.defaultSeverity);
      priorityModel = Model.of(TicketModel.Priority.defaultPriority);
      setStatelessHint(false);
      setOutputMarkupId(true);
      Form<Void> form = new Form<Void>("editForm") {
      Form<Void> form = new Form<Void>("editForm");
      add(form);
      form.add(new DropDownChoice<TicketModel.Type>("type", typeModel, Arrays.asList(TicketModel.Type.choices())));
      form.add(new TextField<String>("title", titleModel));
      form.add(new TextField<String>("topic", topicModel));
      form.add(new DropDownChoice<TicketModel.Severity>("severity", severityModel, Arrays.asList(TicketModel.Severity.choices())));
      final IModel<String> markdownPreviewModel = Model.of();
      descriptionPreview = new Label("descriptionPreview", markdownPreviewModel);
      descriptionPreview.setEscapeModelStrings(false);
      descriptionPreview.setOutputMarkupId(true);
      form.add(descriptionPreview);
      descriptionEditor = new MarkdownTextArea("description", markdownPreviewModel, descriptionPreview);
      descriptionEditor.setRepository(repositoryName);
      form.add(descriptionEditor);
      if (currentUser.canAdmin(null, getRepositoryModel())) {
         // responsible
         Set<String> userlist = new TreeSet<String>();
         if (UserModel.ANONYMOUS.canPush(getRepositoryModel())
               || AuthorizationControl.AUTHENTICATED == getRepositoryModel().authorizationControl) {
            //    authorization is ANONYMOUS or AUTHENTICATED (i.e. all users can be set responsible)
            userlist.addAll(app().users().getAllUsernames());
         } else {
            // authorization is by NAMED users (users with PUSH permission can be set responsible)
            for (RegistrantAccessPermission rp : app().repositories().getUserAccessPermissions(getRepositoryModel())) {
               if (rp.permission.atLeast(AccessPermission.PUSH)) {
                  userlist.add(rp.registrant);
               }
            }
         }
         List<TicketResponsible> responsibles = new ArrayList<TicketResponsible>();
         for (String username : userlist) {
            UserModel user = app().users().getUserModel(username);
            if (user != null && !user.disabled) {
               TicketResponsible responsible = new TicketResponsible(user);
               responsibles.add(responsible);
            }
         }
         Collections.sort(responsibles);
         Fragment responsible = new Fragment("responsible", "responsibleFragment", this);
         responsible.add(new DropDownChoice<TicketResponsible>("responsible", responsibleModel, responsibles));
         form.add(responsible.setVisible(!responsibles.isEmpty()));
         // milestone
         List<TicketMilestone> milestones = app().tickets().getMilestones(getRepositoryModel(), Status.Open);
         Fragment milestone = new Fragment("milestone", "milestoneFragment", this);
         milestone.add(new DropDownChoice<TicketMilestone>("milestone", milestoneModel, milestones));
         form.add(milestone.setVisible(!milestones.isEmpty()));
         // priority
         Fragment priority = new Fragment("priority", "priorityFragment", this);
         priority.add(new DropDownChoice<TicketModel.Priority>("priority", priorityModel, Arrays.asList(TicketModel.Priority.choices())));
         form.add(priority);
         // integration branch
         List<String> branches = new ArrayList<String>();
         for (String branch : getRepositoryModel().getLocalBranches()) {
            // exclude ticket branches
            if (!branch.startsWith(Constants.R_TICKET)) {
               branches.add(Repository.shortenRefName(branch));
            }
         }
         branches.remove(Repository.shortenRefName(getRepositoryModel().HEAD));
         branches.add(0, Repository.shortenRefName(getRepositoryModel().HEAD));
         Fragment mergeto = new Fragment("mergeto", "mergeToFragment", this);
         mergeto.add(new DropDownChoice<String>("mergeto", mergeToModel, branches));
         form.add(mergeto.setVisible(!branches.isEmpty()));
      } else {
         // user does not have permission to assign milestone, responsible, or mergeto
         form.add(new Label("responsible").setVisible(false));
         form.add(new Label("milestone").setVisible(false));
         form.add(new Label("mergeto").setVisible(false));
         form.add(new Label("priority").setVisible(false));
      }
      form.add(new AjaxButton("create") {
         private static final long serialVersionUID = 1L;
         @Override
         protected void onSubmit() {
         protected void onSubmit(AjaxRequestTarget target, Form<?> form) {
            String title = titleModel.getObject();
            if (StringUtils.isEmpty(title)) {
               return;
            }
            String createdBy = GitBlitWebSession.get().getUsername();
            Change change = new Change(createdBy);
            change.setField(Field.title, titleModel.getObject());
            change.setField(Field.title, title);
            change.setField(Field.body, descriptionEditor.getText());
            String topic = topicModel.getObject();
            if (!StringUtils.isEmpty(topic)) {
@@ -128,6 +225,20 @@
               change.setField(Field.milestone, milestone.name);
            }
            // severity
            TicketModel.Severity severity = TicketModel.Severity.defaultSeverity;
            if (severityModel.getObject() != null) {
               severity = severityModel.getObject();
            }
            change.setField(Field.severity, severity);
            // priority
            TicketModel.Priority priority = TicketModel.Priority.defaultPriority;
            if (priorityModel.getObject() != null) {
               priority = priorityModel.getObject();
            }
            change.setField(Field.priority, priority);
            // integration branch
            String mergeTo = mergeToModel.getObject();
            if (!StringUtils.isEmpty(mergeTo)) {
@@ -138,72 +249,14 @@
            if (ticket != null) {
               TicketNotifier notifier = app().tickets().createNotifier();
               notifier.sendMailing(ticket);
               setResponsePage(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number));
               redirectTo(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number));
            } else {
               // TODO error
            }
         }
      };
      add(form);
      });
      form.add(new DropDownChoice<TicketModel.Type>("type", typeModel, Arrays.asList(TicketModel.Type.choices())));
      form.add(new TextField<String>("title", titleModel));
      form.add(new TextField<String>("topic", topicModel));
      final IModel<String> markdownPreviewModel = new Model<String>();
      descriptionPreview = new Label("descriptionPreview", markdownPreviewModel);
      descriptionPreview.setEscapeModelStrings(false);
      descriptionPreview.setOutputMarkupId(true);
      form.add(descriptionPreview);
      descriptionEditor = new MarkdownTextArea("description", markdownPreviewModel, descriptionPreview);
      descriptionEditor.setRepository(repositoryName);
      form.add(descriptionEditor);
      if (currentUser.canAdmin(null, getRepositoryModel())) {
         // responsible
         List<TicketResponsible> responsibles = new ArrayList<TicketResponsible>();
         for (RegistrantAccessPermission rp : app().repositories().getUserAccessPermissions(getRepositoryModel())) {
            if (rp.permission.atLeast(AccessPermission.PUSH) && !rp.isTeam()) {
               UserModel user = app().users().getUserModel(rp.registrant);
               if (user != null) {
                  responsibles.add(new TicketResponsible(user));
               }
            }
         }
         Collections.sort(responsibles);
         Fragment responsible = new Fragment("responsible", "responsibleFragment", this);
         responsible.add(new DropDownChoice<TicketResponsible>("responsible", responsibleModel, responsibles));
         form.add(responsible.setVisible(!responsibles.isEmpty()));
         // milestone
         List<TicketMilestone> milestones = app().tickets().getMilestones(getRepositoryModel(), Status.Open);
         Fragment milestone = new Fragment("milestone", "milestoneFragment", this);
         milestone.add(new DropDownChoice<TicketMilestone>("milestone", milestoneModel, milestones));
         form.add(milestone.setVisible(!milestones.isEmpty()));
         // integration branch
         List<String> branches = new ArrayList<String>();
         for (String branch : getRepositoryModel().getLocalBranches()) {
            // exclude ticket branches
            if (!branch.startsWith(Constants.R_TICKET)) {
               branches.add(Repository.shortenRefName(branch));
            }
         }
         branches.remove(Repository.shortenRefName(getRepositoryModel().HEAD));
         branches.add(0, Repository.shortenRefName(getRepositoryModel().HEAD));
         Fragment mergeto = new Fragment("mergeto", "mergeToFragment", this);
         mergeto.add(new DropDownChoice<String>("mergeto", mergeToModel, branches));
         form.add(mergeto.setVisible(!branches.isEmpty()));
      } else {
         // user does not have permission to assign milestone, responsible, or mergeto
         form.add(new Label("responsible").setVisible(false));
         form.add(new Label("milestone").setVisible(false));
         form.add(new Label("mergeto").setVisible(false));
      }
      form.add(new Button("create"));
      Button cancel = new Button("cancel") {
         private static final long serialVersionUID = 1L;