Critical fix for servlet.

James Moger

2011-05-19 9da97003c7f33a64ae5060f413f9c4c5d26efe78

 src/com/gitblit/wicket/pages/CommitPage.java

@@ -14,10 +14,13 @@
import org.eclipse.jgit.revwalk.RevCommit;



import com.gitblit.utils.JGitUtils;

import com.gitblit.utils.JGitUtils.SearchType;

import com.gitblit.wicket.LinkPanel;

import com.gitblit.wicket.RepositoryPage;

import com.gitblit.wicket.WicketUtils;

import com.gitblit.wicket.models.PathModel;

import com.gitblit.wicket.models.PathModel.PathChangeModel;

import com.gitblit.wicket.panels.CommitHeaderPanel;

import com.gitblit.wicket.panels.CommitLegendPanel;



public class CommitPage extends RepositoryPage {



@@ -25,7 +28,7 @@
      super(params);



      Repository r = getRepository();

      RevCommit c = JGitUtils.getCommit(r, objectId);

      RevCommit c = getCommit();



      List<String> parents = new ArrayList<String>();

      if (c.getParentCount() > 0) {

@@ -44,14 +47,16 @@
      }

      add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newObjectParameter(repositoryName, objectId)));



      add(new LinkPanel("shortlog", "title", c.getShortMessage(), CommitDiffPage.class, WicketUtils.newObjectParameter(repositoryName, objectId)));

      add(new CommitHeaderPanel("commitHeader", repositoryName, c));



      addRefs(r, c);



      add(new Label("commitAuthor", JGitUtils.getDisplayName(c.getAuthorIdent())));

      // author

      add(createPersonPanel("commitAuthor", c.getAuthorIdent(), SearchType.AUTHOR));

      add(WicketUtils.createTimestampLabel("commitAuthorDate", c.getAuthorIdent().getWhen(), getTimeZone()));



      add(new Label("commitCommitter", JGitUtils.getDisplayName(c.getCommitterIdent())));

      // committer

      add(createPersonPanel("commitCommitter", c.getCommitterIdent(), SearchType.COMMITTER));

      add(WicketUtils.createTimestampLabel("commitCommitterDate", c.getCommitterIdent().getWhen(), getTimeZone()));



      add(new Label("commitId", c.getName()));

@@ -75,14 +80,19 @@
      addFullText("fullMessage", c.getFullMessage(), true);



      // changed paths list

      List<PathModel> paths = JGitUtils.getFilesInCommit(r, c);

      ListDataProvider<PathModel> pathsDp = new ListDataProvider<PathModel>(paths);

      DataView<PathModel> pathsView = new DataView<PathModel>("changedPath", pathsDp) {

      List<PathChangeModel> paths = JGitUtils.getFilesInCommit(r, c);	
      add(new CommitLegendPanel("commitLegend", paths));

      ListDataProvider<PathChangeModel> pathsDp = new ListDataProvider<PathChangeModel>(paths);

      DataView<PathChangeModel> pathsView = new DataView<PathChangeModel>("changedPath", pathsDp) {

         private static final long serialVersionUID = 1L;

         int counter = 0;



         public void populateItem(final Item<PathModel> item) {

            final PathModel entry = item.getModelObject();

         public void populateItem(final Item<PathChangeModel> item) {

            final PathChangeModel entry = item.getModelObject();

            Label changeType = new Label("changeType", "");

            WicketUtils.setChangeTypeCssClass(changeType, entry.changeType);

            setChangeTypeTooltip(changeType, entry.changeType);

            item.add(changeType);

            if (entry.isTree()) {

               item.add(new LinkPanel("pathName", null, entry.path, TreePage.class, newPathParameter(entry.path)));

            } else {