Critical fix for servlet.

James Moger

2011-05-19 9da97003c7f33a64ae5060f413f9c4c5d26efe78

 src/com/gitblit/wicket/pages/BlobDiffPage.java

@@ -6,11 +6,14 @@
import org.eclipse.jgit.lib.Repository;

import org.eclipse.jgit.revwalk.RevCommit;



import com.gitblit.GitBlit;

import com.gitblit.Keys;

import com.gitblit.utils.JGitUtils;

import com.gitblit.utils.JGitUtils.DiffOutputType;

import com.gitblit.utils.StringUtils;

import com.gitblit.wicket.LinkPanel;

import com.gitblit.wicket.RepositoryPage;

import com.gitblit.wicket.WicketUtils;

import com.gitblit.wicket.panels.CommitHeaderPanel;

import com.gitblit.wicket.panels.PathBreadcrumbsPanel;



public class BlobDiffPage extends RepositoryPage {

@@ -22,19 +25,22 @@
      final String baseObjectId = WicketUtils.getBaseObjectId(params);



      Repository r = getRepository();

      RevCommit commit = JGitUtils.getCommit(r, objectId);

		
      RevCommit commit = getCommit();

				
      DiffOutputType diffType = DiffOutputType.forName(GitBlit.self().settings().getString(Keys.web.diffStyle, DiffOutputType.GITBLIT.name()));



      String diff;

      if (StringUtils.isEmpty(baseObjectId)) {

         // use first parent

         diff = JGitUtils.getCommitDiff(r, commit, blobPath, true);

         diff = JGitUtils.getCommitDiff(r, commit, blobPath, diffType);

         add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newPathParameter(repositoryName, objectId, blobPath)));

      } else {

         // base commit specified

         RevCommit baseCommit = JGitUtils.getCommit(r, baseObjectId);

         diff = JGitUtils.getCommitDiff(r, baseCommit, commit, blobPath, true);

         diff = JGitUtils.getCommitDiff(r, baseCommit, commit, blobPath, diffType);

         add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newBlobDiffParameter(repositoryName, baseObjectId, objectId, blobPath)));

      }

      

      add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newPathParameter(repositoryName, objectId, blobPath)));

      add(new BookmarkablePageLink<Void>("commitLink", CommitPage.class, WicketUtils.newObjectParameter(repositoryName, objectId)));

      add(new BookmarkablePageLink<Void>("commitDiffLink", CommitDiffPage.class, WicketUtils.newObjectParameter(repositoryName, objectId)));



@@ -42,7 +48,7 @@
      add(new Label("blameLink", getString("gb.blame")));

      add(new BookmarkablePageLink<Void>("historyLink", HistoryPage.class, WicketUtils.newPathParameter(repositoryName, objectId, blobPath)));



      add(new LinkPanel("shortlog", "title", commit.getShortMessage(), CommitPage.class, newCommitParameter()));

      add(new CommitHeaderPanel("commitHeader", repositoryName, commit));



      add(new PathBreadcrumbsPanel("breadcrumbs", repositoryName, blobPath, objectId));