Eliminate nearly all direct GitBlit singleton references in Wicket

James Moger

2013-11-16 99d0d4fd66f3490b61c700065b7d16bc4e73f226

 src/main/java/com/gitblit/wicket/pages/CommitPage.java

@@ -32,19 +32,22 @@
import org.eclipse.jgit.revwalk.RevCommit;



import com.gitblit.Constants;

import com.gitblit.GitBlit;

import com.gitblit.models.GitNote;

import com.gitblit.models.PathModel.PathChangeModel;

import com.gitblit.models.SubmoduleModel;

import com.gitblit.utils.JGitUtils;

import com.gitblit.wicket.CacheControl;

import com.gitblit.wicket.CacheControl.LastModified;

import com.gitblit.wicket.WicketUtils;

import com.gitblit.wicket.panels.CommitHeaderPanel;

import com.gitblit.wicket.panels.CommitLegendPanel;

import com.gitblit.wicket.panels.CompressedDownloadsPanel;

import com.gitblit.wicket.panels.DiffStatPanel;

import com.gitblit.wicket.panels.GravatarImage;

import com.gitblit.wicket.panels.LinkPanel;

import com.gitblit.wicket.panels.RefsPanel;



@CacheControl(LastModified.BOOT)

public class CommitPage extends RepositoryPage {



   public CommitPage(PageParameters params) {

@@ -52,7 +55,7 @@


      Repository r = getRepository();

      RevCommit c = getCommit();

		


      List<String> parents = new ArrayList<String>();

      if (c.getParentCount() > 0) {

         for (RevCommit parent : c.getParents()) {

@@ -82,7 +85,7 @@
      add(createPersonPanel("commitAuthor", c.getAuthorIdent(), Constants.SearchType.AUTHOR));

      add(WicketUtils.createTimestampLabel("commitAuthorDate", c.getAuthorIdent().getWhen(),

            getTimeZone(), getTimeUtils()));

		


      // committer

      add(createPersonPanel("commitCommitter", c.getCommitterIdent(), Constants.SearchType.COMMITTER));

      add(WicketUtils.createTimestampLabel("commitCommitterDate",

@@ -94,7 +97,7 @@
            newCommitParameter()));

      add(new BookmarkablePageLink<Void>("treeLink", TreePage.class, newCommitParameter()));

      final String baseUrl = WicketUtils.getGitblitURL(getRequest());

		


      add(new CompressedDownloadsPanel("compressedLinks", baseUrl, repositoryName, objectId, null));



      // Parent Commits

@@ -102,6 +105,7 @@
      DataView<String> parentsView = new DataView<String>("commitParents", parentsDp) {

         private static final long serialVersionUID = 1L;



         @Override

         public void populateItem(final Item<String> item) {

            String entry = item.getModelObject();

            item.add(new LinkPanel("commitParent", "list", entry, CommitPage.class,

@@ -114,7 +118,7 @@
      };

      add(parentsView);



      addFullText("fullMessage", c.getFullMessage(), true);

      addFullText("fullMessage", c.getFullMessage());



      // git notes

      List<GitNote> notes = JGitUtils.getNotesOnCommit(r, c);

@@ -122,6 +126,7 @@
      DataView<GitNote> notesView = new DataView<GitNote>("notes", notesDp) {

         private static final long serialVersionUID = 1L;



         @Override

         public void populateItem(final Item<GitNote> item) {

            GitNote entry = item.getModelObject();

            item.add(new RefsPanel("refName", repositoryName, Arrays.asList(entry.notesRef)));

@@ -130,27 +135,39 @@
            item.add(new GravatarImage("noteAuthorAvatar", entry.notesRef.getAuthorIdent()));

            item.add(WicketUtils.createTimestampLabel("authorDate", entry.notesRef

                  .getAuthorIdent().getWhen(), getTimeZone(), getTimeUtils()));

            item.add(new Label("noteContent", GitBlit.self().processCommitMessage(

                  repositoryName, entry.content)).setEscapeModelStrings(false));

            item.add(new Label("noteContent", messageProcessor().processPlainCommitMessage(repositoryName,

                  entry.content)).setEscapeModelStrings(false));

         }

      };

      add(notesView.setVisible(notes.size() > 0));



      // changed paths list

      List<PathChangeModel> paths = JGitUtils.getFilesInCommit(r, c);



      // add commit diffstat

      int insertions = 0;

      int deletions = 0;

      for (PathChangeModel pcm : paths) {

         insertions += pcm.insertions;

         deletions += pcm.deletions;

      }

      add(new DiffStatPanel("diffStat", insertions, deletions));



      add(new CommitLegendPanel("commitLegend", paths));

      ListDataProvider<PathChangeModel> pathsDp = new ListDataProvider<PathChangeModel>(paths);

      DataView<PathChangeModel> pathsView = new DataView<PathChangeModel>("changedPath", pathsDp) {

         private static final long serialVersionUID = 1L;

         int counter;



         @Override

         public void populateItem(final Item<PathChangeModel> item) {

            final PathChangeModel entry = item.getModelObject();

            Label changeType = new Label("changeType", "");

            WicketUtils.setChangeTypeCssClass(changeType, entry.changeType);

            setChangeTypeTooltip(changeType, entry.changeType);

            item.add(changeType);

				
            item.add(new DiffStatPanel("diffStat", entry.insertions, entry.deletions, true));



            boolean hasSubmodule = false;

            String submodulePath = null;

            if (entry.isTree()) {

@@ -164,7 +181,7 @@
               SubmoduleModel submodule = getSubmodule(entry.path);

               submodulePath = submodule.gitblitPath;

               hasSubmodule = submodule.hasSubmodule;

					


               item.add(new LinkPanel("pathName", "list", entry.path + " @ " +

                     getShortObjectId(submoduleId), TreePage.class,

                     WicketUtils.newPathParameter(submodulePath, submoduleId, "")).setEnabled(hasSubmodule));

@@ -180,10 +197,13 @@
                     WicketUtils

                           .newPathParameter(repositoryName, entry.commitId, path)));

            }



            

            // quick links

            if (entry.isSubmodule()) {

               // submodule					
               item.add(new ExternalLink("raw", "").setEnabled(false));

					
               // submodule

               item.add(new BookmarkablePageLink<Void>("diff", BlobDiffPage.class, WicketUtils

                     .newPathParameter(repositoryName, entry.commitId, entry.path))

                     .setEnabled(!entry.changeType.equals(ChangeType.ADD)));

@@ -200,10 +220,15 @@
                     .setEnabled(!entry.changeType.equals(ChangeType.ADD)

                           && !entry.changeType.equals(ChangeType.DELETE)));

               item.add(new BookmarkablePageLink<Void>("view", BlobPage.class, WicketUtils

                     .newPathParameter(repositoryName, entry.commitId, entry.path)));

                     .newPathParameter(repositoryName, entry.commitId, entry.path))

                     .setEnabled(!entry.changeType.equals(ChangeType.DELETE)));

               item.add(new BookmarkablePageLink<Void>("raw", RawPage.class, WicketUtils

                     .newPathParameter(repositoryName, entry.commitId, entry.path))

                     .setEnabled(!entry.changeType.equals(ChangeType.DELETE)));

               item.add(new BookmarkablePageLink<Void>("blame", BlamePage.class, WicketUtils

                     .newPathParameter(repositoryName, entry.commitId, entry.path))

                     .setEnabled(!entry.changeType.equals(ChangeType.ADD)));

                     .setEnabled(!entry.changeType.equals(ChangeType.ADD)

                           && !entry.changeType.equals(ChangeType.DELETE)));

               item.add(new BookmarkablePageLink<Void>("history", HistoryPage.class, WicketUtils

                     .newPathParameter(repositoryName, entry.commitId, entry.path))

                     .setEnabled(!entry.changeType.equals(ChangeType.ADD)));

@@ -220,4 +245,9 @@
   protected String getPageName() {

      return getString("gb.commit");

   }



   @Override

   protected Class<? extends BasePage> getRepoNavPageClass() {

      return LogPage.class;

   }

}