Protect DownloadZipServlet with an AccessRestrictionFilter.

James Moger

2011-09-26 78753bc22f140f863aa3fe56b1c59699ca3e2fa8

 src/WEB-INF/web.xml

@@ -15,23 +15,15 @@
       <url-pattern> MUST match: 

         * GitFilter

         * com.gitblit.Constants.GIT_PATH

         * Wicket Filter ignorePaths parameter --><!-- STRIP

         * Wicket Filter ignorePaths parameter -->

   <servlet>

      <servlet-name>GitServlet</servlet-name>

      <servlet-class>org.jgit.http.transport.GitServlet</servlet-class>

      <init-param>

         <param-name>base-path</param-name>

         <param-value>c:/git</param-value>

      </init-param>

      <init-param>

         <param-name>export-all</param-name>

         <param-value>1</param-value>

      </init-param>

      <servlet-class>com.gitblit.GitServlet</servlet-class>

   </servlet>

   <servlet-mapping>

      <servlet-name>GitServlet</servlet-name>      

      <url-pattern>/git/*</url-pattern>

   </servlet-mapping>STRIP -->

   </servlet-mapping>

   

   

   <!-- Syndication Servlet

@@ -63,6 +55,20 @@
      <url-pattern>/zip/*</url-pattern>

   </servlet-mapping>

   

	
   <!-- Federation Servlet

       <url-pattern> MUST match: 
          * com.gitblit.Constants.FEDERATION_PATH		 
         * Wicket Filter ignorePaths parameter -->

   <servlet>

      <servlet-name>FederationServlet</servlet-name>

      <servlet-class>com.gitblit.FederationServlet</servlet-class>		
   </servlet>

   <servlet-mapping>

      <servlet-name>FederationServlet</servlet-name>

      <url-pattern>/federation/*</url-pattern>

   </servlet-mapping>	
	


   <!-- Git Access Restriction Filter

       <url-pattern> MUST match: 

@@ -92,7 +98,21 @@
      <filter-name>SyndicationFilter</filter-name>

      <url-pattern>/feed/*</url-pattern>

   </filter-mapping>



	
	
   <!-- Download Zip Restriction Filter

       <url-pattern> MUST match: 
         * DownloadZipServlet

         * com.gitblit.Constants.ZIP_PATH

         * Wicket Filter ignorePaths parameter -->

   <filter>

      <filter-name>ZipFilter</filter-name>

      <filter-class>com.gitblit.DownloadZipFilter</filter-class>

   </filter>

   <filter-mapping>

      <filter-name>ZipFilter</filter-name>

      <url-pattern>/zip/*</url-pattern>

   </filter-mapping>

      

   <!-- Wicket Filter -->

    <filter>

@@ -113,9 +133,11 @@
                * GitFilter <url-pattern>

                * GitServlet <url-pattern>

                * com.gitblit.Constants.GIT_PATH

                * Zipfilter <url-pattern>

                * ZipServlet <url-pattern>

                * com.gitblit.Constants.ZIP_PATH -->

            <param-value>git/,feed/,zip/</param-value>

                * com.gitblit.Constants.ZIP_PATH

                * FederationServlet <url-pattern> -->

            <param-value>git/,feed/,zip/,federation/</param-value>

        </init-param>

    </filter>

    <filter-mapping>