Ensure a repository is only searched once

James Moger

2015-10-05 548b29e87dedac76bad2011cda4e39a9f3d72a21

 src/main/java/com/gitblit/tickets/BranchTicketService.java

@@ -297,7 +297,7 @@
         log.error("failed to read " + file, e);
      } finally {
         if (rw != null) {
            rw.release();
            rw.close();
         }
      }
      return null;
@@ -353,7 +353,7 @@
      } catch (IOException e) {
         log.error("", e);
      } finally {
         inserter.release();
         inserter.close();
      }
   }

@@ -712,7 +712,7 @@
         } finally {
            // release the treewalk
            if (treeWalk != null) {
               treeWalk.release();
               treeWalk.close();
            }
         }
      } finally {
@@ -811,7 +811,7 @@
         // finish the index
         builder.finish();
      } finally {
         inserter.release();
         inserter.close();
      }
      return newIndex;
   }
@@ -828,8 +828,12 @@
      List<DirCacheEntry> list = new ArrayList<DirCacheEntry>();
      TreeWalk tw = null;
      try {
         tw = new TreeWalk(db);
         ObjectId treeId = db.resolve(BRANCH + "^{tree}");
         if (treeId == null) {
            // branch does not exist yet, could be migrating tickets
            return list;
         }
         tw = new TreeWalk(db);
         int hIdx = tw.addTree(treeId);
         tw.setRecursive(true);

@@ -851,7 +855,7 @@
         }
      } finally {
         if (tw != null) {
            tw.release();
            tw.close();
         }
      }
      return list;
@@ -909,10 +913,10 @@
                     rc));
            }
         } finally {
            revWalk.release();
            revWalk.close();
         }
      } finally {
         odi.release();
         odi.close();
      }
      return success;
   }