Findbugs. CodePro Audit. Checkstyle. Unit test refactoring.

James Moger

2011-05-26 2a7306a1d92522569a8bb6e5a7c0bcdd5cf4cfaa

 src/com/gitblit/wicket/panels/BranchesPanel.java

@@ -43,7 +43,8 @@


   private static final long serialVersionUID = 1L;



   public BranchesPanel(String wicketId, final RepositoryModel model, Repository r, final int maxCount) {

   public BranchesPanel(String wicketId, final RepositoryModel model, Repository r,

         final int maxCount) {

      super(wicketId);



      // branches

@@ -61,31 +62,38 @@
      if (maxCount > 0) {

         // summary page

         // show branches page link

         add(new LinkPanel("branches", "title", new StringResourceModel("gb.branches", this, null), BranchesPage.class, WicketUtils.newRepositoryParameter(model.name)));

         add(new LinkPanel("branches", "title", new StringResourceModel("gb.branches", this,

               null), BranchesPage.class, WicketUtils.newRepositoryParameter(model.name)));

      } else {

         // branches page

         // show repository summary page link

         add(new LinkPanel("branches", "title", model.name, SummaryPage.class, WicketUtils.newRepositoryParameter(model.name)));

         add(new LinkPanel("branches", "title", model.name, SummaryPage.class,

               WicketUtils.newRepositoryParameter(model.name)));

      }



      ListDataProvider<RefModel> branchesDp = new ListDataProvider<RefModel>(branches);

      DataView<RefModel> branchesView = new DataView<RefModel>("branch", branchesDp) {

         private static final long serialVersionUID = 1L;

         int counter = 0;

         int counter;



         public void populateItem(final Item<RefModel> item) {

            final RefModel entry = item.getModelObject();



            item.add(WicketUtils.createDateLabel("branchDate", entry.getDate(), getTimeZone()));



            item.add(new LinkPanel("branchName", "list name", StringUtils.trimString(entry.getDisplayName(), 28), LogPage.class, WicketUtils.newObjectParameter(model.name, entry.getName())));

            item.add(new LinkPanel("branchName", "list name", StringUtils.trimString(

                  entry.displayName, 28), LogPage.class, WicketUtils.newObjectParameter(

                  model.name, entry.getName())));



            // only show branch type on the branches page

            boolean remote = entry.getName().startsWith(Constants.R_REMOTES);

            item.add(new Label("branchType", remote ? getString("gb.remote") : getString("gb.local")).setVisible(maxCount <= 0));

            item.add(new Label("branchType", remote ? getString("gb.remote")

                  : getString("gb.local")).setVisible(maxCount <= 0));



            item.add(new BookmarkablePageLink<Void>("log", LogPage.class, WicketUtils.newObjectParameter(model.name, entry.getName())));

            item.add(new BookmarkablePageLink<Void>("tree", TreePage.class, WicketUtils.newObjectParameter(model.name, entry.getName())));

            item.add(new BookmarkablePageLink<Void>("log", LogPage.class, WicketUtils

                  .newObjectParameter(model.name, entry.getName())));

            item.add(new BookmarkablePageLink<Void>("tree", TreePage.class, WicketUtils

                  .newObjectParameter(model.name, entry.getName())));



            WicketUtils.setAlternatingBackground(item, counter);

            counter++;

@@ -95,7 +103,8 @@
      if (branches.size() < maxCount || maxCount <= 0) {

         add(new Label("allBranches", "").setVisible(false));

      } else {

         add(new LinkPanel("allBranches", "link", new StringResourceModel("gb.allBranches", this, null), BranchesPage.class, WicketUtils.newRepositoryParameter(model.name)));

         add(new LinkPanel("allBranches", "link", new StringResourceModel("gb.allBranches",

               this, null), BranchesPage.class, WicketUtils.newRepositoryParameter(model.name)));

      }

   }

}