[findbugs] Clarify class used for resource loading

James Moger

2014-04-17 1d78b8b372f15d89f10fd32cb0227a6a7966de3c

 src/main/java/com/gitblit/wicket/pages/TicketsPage.java

@@ -87,7 +87,7 @@
      // set stateless page preference

      setStatelessHint(true);



      any = new TicketResponsible("any", "[* TO *]", null);

      any = new TicketResponsible(getString("gb.any"), "[* TO *]", null);



      UserModel user = GitBlitWebSession.get().getUser();

      boolean isAuthenticated = user != null && user.isAuthenticated;

@@ -164,6 +164,9 @@
         if (currentMilestone == null) {

            // milestone not found, create a temporary one

            currentMilestone = new TicketMilestone(milestoneParam);

            String q = QueryBuilder.q(Lucene.rid.matches(getRepositoryModel().getRID())).and(Lucene.milestone.matches(milestoneParam)).build();

            currentMilestone.tickets = app().tickets().queryFor(q, 1, 0, Lucene.number.name(), true);

            milestones.add(currentMilestone);

         }

      }



@@ -185,16 +188,16 @@
         milestonePanel.add(label);



         milestonePanel.add(new LinkPanel("openTickets", null,

               currentMilestone.getOpenTickets() + " open",

               MessageFormat.format(getString("gb.nOpenTickets"), currentMilestone.getOpenTickets()),

               TicketsPage.class,

               queryParameters(null, currentMilestone.name, openStatii, null, sortBy, desc, 1)));



         milestonePanel.add(new LinkPanel("closedTickets", null,

               currentMilestone.getClosedTickets() + " closed",

               MessageFormat.format(getString("gb.nClosedTickets"), currentMilestone.getClosedTickets()),

               TicketsPage.class,

               queryParameters(null, currentMilestone.name, closedStatii, null, sortBy, desc, 1)));



         milestonePanel.add(new Label("totalTickets", currentMilestone.getTotalTickets() + " total"));

         milestonePanel.add(new Label("totalTickets", MessageFormat.format(getString("gb.nTotalTickets"), currentMilestone.getTotalTickets())));

         add(milestonePanel);

      }



@@ -397,7 +400,8 @@
      add(new BookmarkablePageLink<Void>("allTickets", TicketsPage.class, queryParameters(queryParam, milestoneParam, null, assignedToParam, sortBy, desc, 1)));



      // by status

      List<Status> statii = Arrays.asList(Status.values());

      List<Status> statii = new ArrayList<Status>(Arrays.asList(Status.values()));

      statii.remove(Status.Closed);

      ListDataProvider<Status> resolutionsDp = new ListDataProvider<Status>(statii);

      DataView<Status> statiiLinks = new DataView<Status>("statii", resolutionsDp) {

         private static final long serialVersionUID = 1L;

@@ -529,7 +533,7 @@


               @Override

               public void populateItem(final Item<String> labelItem) {

                  String content = messageProcessor().processPlainCommitMessage(getRepository(), repositoryName, labelItem.getModelObject());

                  String content = bugtraqProcessor().processPlainCommitMessage(getRepository(), repositoryName, labelItem.getModelObject());

                  Label label = new Label("label", content);

                  label.setEscapeModelStrings(false);

                  TicketLabel tLabel = app().tickets().getLabel(getRepositoryModel(), labelItem.getModelObject());

@@ -642,15 +646,35 @@
      };

      add(ticketsView);



      DataView<TicketMilestone> milestonesList = new DataView<TicketMilestone>("milestoneList", milestonesDp) {

      List<TicketMilestone> allMilestones = app().tickets().getMilestones(getRepositoryModel());

      ListDataProvider<TicketMilestone> allMilestonesDp = new ListDataProvider<TicketMilestone>(allMilestones);

      DataView<TicketMilestone> milestonesList = new DataView<TicketMilestone>("milestoneList", allMilestonesDp) {

         private static final long serialVersionUID = 1L;



         @Override

         public void populateItem(final Item<TicketMilestone> item) {

            final TicketMilestone tm = item.getModelObject();

            item.add(new Label("milestoneName", tm.name));

            item.add(new Label("milestoneState", tm.status.name()));

            item.add(new Label("milestoneDue", tm.due == null ? getString("gb.notSpecified") : tm.due.toString()));

            PageParameters params = queryParameters(null, tm.name, null, null, null, desc, 1);

            item.add(new LinkPanel("milestoneName", null, tm.name, TicketsPage.class, params).setRenderBodyOnly(true));



            String css;

            switch (tm.status) {

            case Open:

               css = "aui-lozenge aui-lozenge-subtle";

               break;

            default:

               css = "aui-lozenge";

               break;

            }

            Label stateLabel = new Label("milestoneState", tm.status.name());

            WicketUtils.setCssClass(stateLabel, css);

            item.add(stateLabel);



            if (tm.due == null) {

               item.add(new Label("milestoneDue", getString("gb.notSpecified")));

            } else {

               item.add(WicketUtils.createDatestampLabel("milestoneDue", tm.due, getTimeZone(), getTimeUtils()));

            }

         }

      };

      add(milestonesList);