[findbugs] Clarify class used for resource loading

James Moger

2014-04-17 1d78b8b372f15d89f10fd32cb0227a6a7966de3c

 src/main/java/com/gitblit/tickets/RedisTicketService.java

@@ -21,8 +21,6 @@
import java.util.List;
import java.util.Set;

import javax.inject.Inject;

import org.apache.commons.pool2.impl.GenericObjectPoolConfig;

import redis.clients.jedis.Client;
@@ -34,6 +32,7 @@

import com.gitblit.Keys;
import com.gitblit.manager.INotificationManager;
import com.gitblit.manager.IPluginManager;
import com.gitblit.manager.IRepositoryManager;
import com.gitblit.manager.IRuntimeManager;
import com.gitblit.manager.IUserManager;
@@ -61,14 +60,15 @@
      journal, ticket, counter
   }

   @Inject
   public RedisTicketService(
         IRuntimeManager runtimeManager,
         IPluginManager pluginManager,
         INotificationManager notificationManager,
         IUserManager userManager,
         IRepositoryManager repositoryManager) {

      super(runtimeManager,
            pluginManager,
            notificationManager,
            userManager,
            repositoryManager);
@@ -171,7 +171,7 @@
      }
      try {
         Boolean exists = jedis.exists(key(repository, KeyType.journal, ticketId));
         return exists != null && !exists;
         return exists != null && exists;
      } catch (JedisException e) {
         log.error("failed to check hasTicket from Redis @ " + getUrl(), e);
         pool.returnBrokenResource(jedis);