James Moger
2012-10-10 20714aee0d2d2a989d93d6065e081aed8ac85fbf
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
package com.gitblit.tests;
 
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
 
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileOutputStream;
import java.io.OutputStreamWriter;
import java.text.MessageFormat;
import java.util.Date;
import java.util.concurrent.atomic.AtomicBoolean;
 
import org.eclipse.jgit.api.CloneCommand;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.ResetCommand.ResetType;
import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.revwalk.RevCommit;
import org.eclipse.jgit.transport.CredentialsProvider;
import org.eclipse.jgit.transport.PushResult;
import org.eclipse.jgit.transport.RefSpec;
import org.eclipse.jgit.transport.RemoteRefUpdate;
import org.eclipse.jgit.transport.RemoteRefUpdate.Status;
import org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider;
import org.eclipse.jgit.util.FileUtils;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;
 
import com.gitblit.Constants.AccessPermission;
import com.gitblit.Constants.AccessRestrictionType;
import com.gitblit.Constants.AuthorizationControl;
import com.gitblit.GitBlit;
import com.gitblit.models.RepositoryModel;
import com.gitblit.models.UserModel;
import com.gitblit.utils.JGitUtils;
 
public class GitServletTest {
 
    static File ticgitFolder = new File(GitBlitSuite.REPOSITORIES, "working/ticgit");
    
    static File ticgit2Folder = new File(GitBlitSuite.REPOSITORIES, "working/ticgit2");
 
    static File jgitFolder = new File(GitBlitSuite.REPOSITORIES, "working/jgit");
    
    static File jgit2Folder = new File(GitBlitSuite.REPOSITORIES, "working/jgit2");
 
    String url = GitBlitSuite.url;
    String account = GitBlitSuite.account;
    String password = GitBlitSuite.password;
 
    private static final AtomicBoolean started = new AtomicBoolean(false);
 
    @BeforeClass
    public static void startGitblit() throws Exception {
        started.set(GitBlitSuite.startGitblit());
    }
 
    @AfterClass
    public static void stopGitblit() throws Exception {
        if (started.get()) {
            GitBlitSuite.stopGitblit();
            deleteWorkingFolders();
        }
    }
    
    public static void deleteWorkingFolders() throws Exception {
        if (ticgitFolder.exists()) {
            FileUtils.delete(ticgitFolder, FileUtils.RECURSIVE);
        }
        if (ticgit2Folder.exists()) {
            FileUtils.delete(ticgit2Folder, FileUtils.RECURSIVE);
        }
        if (jgitFolder.exists()) {
            FileUtils.delete(jgitFolder, FileUtils.RECURSIVE);
        }
        if (jgit2Folder.exists()) {
            FileUtils.delete(jgit2Folder, FileUtils.RECURSIVE);
        }
    }
 
    @Test
    public void testClone() throws Exception {
        CloneCommand clone = Git.cloneRepository();
        clone.setURI(MessageFormat.format("{0}/git/ticgit.git", url));
        clone.setDirectory(ticgitFolder);
        clone.setBare(false);
        clone.setCloneAllBranches(true);
        clone.setCredentialsProvider(new UsernamePasswordCredentialsProvider(account, password));
        close(clone.call());        
        assertTrue(true);
    }
 
    @Test
    public void testBogusLoginClone() throws Exception {
        // restrict repository access
        RepositoryModel model = GitBlit.self().getRepositoryModel("ticgit.git");
        model.accessRestriction = AccessRestrictionType.CLONE;
        GitBlit.self().updateRepositoryModel(model.name, model, false);
 
        // delete any existing working folder        
        boolean cloned = false;
        try {
            CloneCommand clone = Git.cloneRepository();
            clone.setURI(MessageFormat.format("{0}/git/ticgit.git", url));
            clone.setDirectory(ticgit2Folder);
            clone.setBare(false);
            clone.setCloneAllBranches(true);
            clone.setCredentialsProvider(new UsernamePasswordCredentialsProvider("bogus", "bogus"));
            close(clone.call());
            cloned = true;
        } catch (Exception e) {
            // swallow the exception which we expect
        }
 
        // restore anonymous repository access
        model.accessRestriction = AccessRestrictionType.NONE;
        GitBlit.self().updateRepositoryModel(model.name, model, false);
 
        assertFalse("Bogus login cloned a repository?!", cloned);
    }
    
    @Test
    public void testUnauthorizedLoginClone() throws Exception {
        // restrict repository access
        RepositoryModel model = GitBlit.self().getRepositoryModel("ticgit.git");
        model.accessRestriction = AccessRestrictionType.CLONE;
        model.authorizationControl = AuthorizationControl.NAMED;
        UserModel user = new UserModel("james");
        user.password = "james";
        GitBlit.self().updateUserModel(user.username, user, true);
        GitBlit.self().updateRepositoryModel(model.name, model, false);
 
        FileUtils.delete(ticgit2Folder, FileUtils.RECURSIVE);
        
        // delete any existing working folder        
        boolean cloned = false;
        try {
            CloneCommand clone = Git.cloneRepository();
            clone.setURI(MessageFormat.format("{0}/git/ticgit.git", url));
            clone.setDirectory(ticgit2Folder);
            clone.setBare(false);
            clone.setCloneAllBranches(true);
            clone.setCredentialsProvider(new UsernamePasswordCredentialsProvider(user.username, user.password));
            close(clone.call());
            cloned = true;
        } catch (Exception e) {
            // swallow the exception which we expect
        }
 
        assertFalse("Unauthorized login cloned a repository?!", cloned);
 
        FileUtils.delete(ticgit2Folder, FileUtils.RECURSIVE);
        
        // switch to authenticated
        model.authorizationControl = AuthorizationControl.AUTHENTICATED;
        GitBlit.self().updateRepositoryModel(model.name, model, false);
        
        // try clone again
        cloned = false;
        CloneCommand clone = Git.cloneRepository();
        clone.setURI(MessageFormat.format("{0}/git/ticgit.git", url));
        clone.setDirectory(ticgit2Folder);
        clone.setBare(false);
        clone.setCloneAllBranches(true);
        clone.setCredentialsProvider(new UsernamePasswordCredentialsProvider(user.username, user.password));
        close(clone.call());
        cloned = true;
 
        assertTrue("Authenticated login could not clone!", cloned);
        
        FileUtils.delete(ticgit2Folder, FileUtils.RECURSIVE);
        
        // restore anonymous repository access
        model.accessRestriction = AccessRestrictionType.NONE;
        model.authorizationControl = AuthorizationControl.NAMED;
        GitBlit.self().updateRepositoryModel(model.name, model, false);
        GitBlit.self().deleteUser(user.username);
    }
 
    @Test
    public void testAnonymousPush() throws Exception {
        Git git = Git.open(ticgitFolder);
        File file = new File(ticgitFolder, "TODO");
        OutputStreamWriter os = new OutputStreamWriter(new FileOutputStream(file, true), Constants.CHARSET);
        BufferedWriter w = new BufferedWriter(os);
        w.write("// hellol中文 " + new Date().toString() + "\n");
        w.close();
        git.add().addFilepattern(file.getName()).call();
        git.commit().setMessage("test commit").call();
        git.push().setPushAll().call();
        close(git);
    }
 
    @Test
    public void testSubfolderPush() throws Exception {
        CloneCommand clone = Git.cloneRepository();
        clone.setURI(MessageFormat.format("{0}/git/test/jgit.git", url));
        clone.setDirectory(jgitFolder);
        clone.setBare(false);
        clone.setCloneAllBranches(true);
        clone.setCredentialsProvider(new UsernamePasswordCredentialsProvider(account, password));
        close(clone.call());
        assertTrue(true);
 
        Git git = Git.open(jgitFolder);
        File file = new File(jgitFolder, "TODO");
        OutputStreamWriter os = new OutputStreamWriter(new FileOutputStream(file, true), Constants.CHARSET);
        BufferedWriter w = new BufferedWriter(os);
        w.write("// " + new Date().toString() + "\n");
        w.close();
        git.add().addFilepattern(file.getName()).call();
        git.commit().setMessage("test commit").call();
        git.push().setPushAll().call();
        close(git);
    }
    
    @Test
    public void testPushToNonBareRepository() throws Exception {
        CloneCommand clone = Git.cloneRepository();
        clone.setURI(MessageFormat.format("{0}/git/working/jgit", url));
        clone.setDirectory(jgit2Folder);
        clone.setBare(false);
        clone.setCloneAllBranches(true);
        clone.setCredentialsProvider(new UsernamePasswordCredentialsProvider(account, password));
        close(clone.call());
        assertTrue(true);
 
        Git git = Git.open(jgit2Folder);
        File file = new File(jgit2Folder, "NONBARE");
        OutputStreamWriter os = new OutputStreamWriter(new FileOutputStream(file, true), Constants.CHARSET);
        BufferedWriter w = new BufferedWriter(os);
        w.write("// " + new Date().toString() + "\n");
        w.close();
        git.add().addFilepattern(file.getName()).call();
        git.commit().setMessage("test commit followed by push to non-bare repository").call();
        try {
            git.push().setPushAll().call();
            assertTrue(false);
        } catch (Exception e) {
            assertTrue(e.getCause().getMessage().contains("git-receive-pack not permitted"));
        }
        close(git);
    }
 
    @Test
    public void testBlockClone() throws Exception {
        testRefChange(AccessPermission.VIEW, null, null, null);
    }
 
    @Test
    public void testBlockPush() throws Exception {
        testRefChange(AccessPermission.CLONE, null, null, null);
    }
 
    @Test
    public void testBlockBranchCreation() throws Exception {
        testRefChange(AccessPermission.PUSH, Status.REJECTED_OTHER_REASON, null, null);
    }
 
    @Test
    public void testBlockBranchDeletion() throws Exception {
        testRefChange(AccessPermission.CREATE, Status.OK, Status.REJECTED_OTHER_REASON, null);
    }
    
    @Test
    public void testBlockBranchRewind() throws Exception {
        testRefChange(AccessPermission.DELETE, Status.OK, Status.OK, Status.REJECTED_OTHER_REASON);
    }
 
    @Test
    public void testBranchRewind() throws Exception {        
        testRefChange(AccessPermission.REWIND, Status.OK, Status.OK, Status.OK);
    }
 
    private void testRefChange(AccessPermission permission, Status expectedCreate, Status expectedDelete, Status expectedRewind) throws Exception {
 
        UserModel user = new UserModel("james");
        user.password = "james";
        
        if (GitBlit.self().getUserModel(user.username) != null) {
            GitBlit.self().deleteUser(user.username);
        }
        
        CredentialsProvider cp = new UsernamePasswordCredentialsProvider(user.username, user.password);
        
        // fork from original to a temporary bare repo
        File refChecks = new File(GitBlitSuite.REPOSITORIES, "refchecks/ticgit.git");
        if (refChecks.exists()) {
            FileUtils.delete(refChecks, FileUtils.RECURSIVE);
        }
        CloneCommand clone = Git.cloneRepository();
        clone.setURI(MessageFormat.format("{0}/git/ticgit.git", url));
        clone.setDirectory(refChecks);
        clone.setBare(true);
        clone.setCloneAllBranches(true);
        clone.setCredentialsProvider(cp);
        close(clone.call());
 
        // elevate repository to clone permission
        RepositoryModel model = GitBlit.self().getRepositoryModel("refchecks/ticgit.git");
        switch (permission) {
            case VIEW:
                model.accessRestriction = AccessRestrictionType.CLONE;
                break;
            case CLONE:
                model.accessRestriction = AccessRestrictionType.CLONE;
                break;
            default:
                model.accessRestriction = AccessRestrictionType.PUSH;
        }
        model.authorizationControl = AuthorizationControl.NAMED;
        
        // grant user specified
        user.setRepositoryPermission(model.name, permission);
 
        GitBlit.self().updateUserModel(user.username, user, true);
        GitBlit.self().updateRepositoryModel(model.name, model, false);
 
        // clone temp bare repo to working copy
        File local = new File(GitBlitSuite.REPOSITORIES, "refchecks/ticgit-wc");
        if (local.exists()) {
            FileUtils.delete(local, FileUtils.RECURSIVE);
        }
        clone = Git.cloneRepository();
        clone.setURI(MessageFormat.format("{0}/git/{1}", url, model.name));
        clone.setDirectory(local);
        clone.setBare(false);
        clone.setCloneAllBranches(true);
        clone.setCredentialsProvider(cp);
        
        try {
            close(clone.call());
        } catch (GitAPIException e) {
            if (permission.atLeast(AccessPermission.CLONE)) {
                throw e;
            } else {
                // user does not have clone permission
                assertTrue(e.getMessage(), e.getMessage().contains("not permitted"));                
                return;
            }
        }
        
        Git git = Git.open(local);
        
        // commit a file and push it
        File file = new File(local, "PUSHCHK");
        OutputStreamWriter os = new OutputStreamWriter(new FileOutputStream(file, true), Constants.CHARSET);
        BufferedWriter w = new BufferedWriter(os);
        w.write("// " + new Date().toString() + "\n");
        w.close();
        git.add().addFilepattern(file.getName()).call();
        git.commit().setMessage("push test").call();
        Iterable<PushResult> results = null;
        try {
            results = git.push().setCredentialsProvider(cp).setRemote("origin").call();
        } catch (GitAPIException e) {
            if (permission.atLeast(AccessPermission.PUSH)) {
                throw e;
            } else {
                // user does not have push permission
                assertTrue(e.getMessage(), e.getMessage().contains("not permitted"));
                close(git);
                return;
            }
        }
        
        for (PushResult result : results) {
            RemoteRefUpdate ref = result.getRemoteUpdate("refs/heads/master");
            Status status = ref.getStatus();
            if (permission.atLeast(AccessPermission.PUSH)) {
                assertTrue("User failed to push commit?! " + status.name(), Status.OK.equals(status));
            } else {
                assertTrue("User was able to push commit! " + status.name(), Status.REJECTED_OTHER_REASON.equals(status));
                close(git);
                // skip delete test
                return;
            }
        }
        
        // create a local branch and push the new branch back to the origin                
        git.branchCreate().setName("protectme").call();
        RefSpec refSpec = new RefSpec("refs/heads/protectme:refs/heads/protectme");
        results = git.push().setCredentialsProvider(cp).setRefSpecs(refSpec).setRemote("origin").call();
        for (PushResult result : results) {
            RemoteRefUpdate ref = result.getRemoteUpdate("refs/heads/protectme");
            Status status = ref.getStatus();
            if (Status.OK.equals(expectedCreate)) {
                assertTrue("User failed to push creation?! " + status.name(), status.equals(expectedCreate));
            } else {
                assertTrue("User was able to push ref creation! " + status.name(), status.equals(expectedCreate));
                close(git);
                // skip delete test
                return;
            }
        }
        
        // delete the branch locally
        git.branchDelete().setBranchNames("protectme").call();
        
        // push a delete ref command
        refSpec = new RefSpec(":refs/heads/protectme");
        results = git.push().setCredentialsProvider(cp).setRefSpecs(refSpec).setRemote("origin").call();
        for (PushResult result : results) {
            RemoteRefUpdate ref = result.getRemoteUpdate("refs/heads/protectme");
            Status status = ref.getStatus();
            if (Status.OK.equals(expectedDelete)) {
                assertTrue("User failed to push ref deletion?! " + status.name(), status.equals(Status.OK));
            } else {
                assertTrue("User was able to push ref deletion?! " + status.name(), status.equals(expectedDelete));
                close(git);
                // skip rewind test
                return;
            }
        }
        
        // rewind master by two commits
        git.reset().setRef("HEAD~2").setMode(ResetType.HARD).call();
        
        // commit a change on this detached HEAD
        file = new File(local, "REWINDCHK");
        os = new OutputStreamWriter(new FileOutputStream(file, true), Constants.CHARSET);
        w = new BufferedWriter(os);
        w.write("// " + new Date().toString() + "\n");
        w.close();
        git.add().addFilepattern(file.getName()).call();
        RevCommit commit = git.commit().setMessage("rewind master and new commit").call();
        
        // Reset master to our new commit now we our local branch tip is no longer
        // upstream of the remote branch tip.  It is an alternate tip of the branch.
        JGitUtils.setBranchRef(git.getRepository(), "refs/heads/master", commit.getName());
        
        // Try pushing our new tip to the origin.
        // This requires the server to "rewind" it's master branch and update it
        // to point to our alternate tip.  This leaves the original master tip
        // unreferenced.
        results = git.push().setCredentialsProvider(cp).setRemote("origin").setForce(true).call();
        for (PushResult result : results) {
            RemoteRefUpdate ref = result.getRemoteUpdate("refs/heads/master");
            Status status = ref.getStatus();
            if (Status.OK.equals(expectedRewind)) {
                assertTrue("User failed to rewind master?! " + status.name(), status.equals(expectedRewind));
            } else {
                assertTrue("User was able to rewind master?! " + status.name(), status.equals(expectedRewind));
            }
        }
        close(git);
        
        GitBlit.self().deleteUser(user.username);
    }
 
    
    private void close(Git git) {
        // really close the repository
        // decrement the use counter to 0
        for (int i = 0; i < 2; i++) {
            git.getRepository().close();
        }
    }
}